Remove duplicate domain from CORS. fix #16

wparad · wparad · commit 933910fab45b · 2024-05-04T11:44:45.000+02:00
diff --git a/template/cloudformationTemplate.js b/template/cloudformationTemplate.js
@@ -174,7 +174,7 @@ module.exports = {
                 {
                   AllowedHeaders: ['*'],
                   AllowedMethods: ['PUT', 'POST', 'DELETE', 'HEAD', 'GET'],
-                  AllowedOrigins: [{ 'Fn::If': ['DeployCustomDomain', { 'Fn::Sub': 'https://${CustomDomain}' }, 'https://console.rhosys.ch'] }, 'https://console.rhosys.ch', 'http://localhost:8080'],
+                  AllowedOrigins: [{ 'Fn::If': ['DeployCustomDomain', { 'Fn::Sub': 'https://${CustomDomain}' }, { Ref: 'AWS::NoValue' }] }, 'https://console.rhosys.ch', 'http://localhost:8080'],
                   ExposedHeaders: ['x-amz-request-id'],
                   MaxAge: 3600
                 }

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ module.exports = {`
`174`	`174`	`{`
`175`	`175`	`AllowedHeaders: ['*'],`
`176`	`176`	`AllowedMethods: ['PUT', 'POST', 'DELETE', 'HEAD', 'GET'],`
`177`		`- AllowedOrigins: [{ 'Fn::If': ['DeployCustomDomain', { 'Fn::Sub': 'https://${CustomDomain}' }, 'https://console.rhosys.ch'] }, 'https://console.rhosys.ch', 'http://localhost:8080'],`
	`177`	`+ AllowedOrigins: [{ 'Fn::If': ['DeployCustomDomain', { 'Fn::Sub': 'https://${CustomDomain}' }, { Ref: 'AWS::NoValue' }] }, 'https://console.rhosys.ch', 'http://localhost:8080'],`
`178`	`178`	`ExposedHeaders: ['x-amz-request-id'],`
`179`	`179`	`MaxAge: 3600`
`180`	`180`	`}`