Skip to content

Commit d3b4550

Browse files
authored
Only render ItemGroup if there are meta fields (#110)
1 parent 51cb1a9 commit d3b4550

File tree

1 file changed

+34
-38
lines changed

1 file changed

+34
-38
lines changed

includes/manager/src/components/fields-ui.js

+34-38
Original file line numberDiff line numberDiff line change
@@ -37,51 +37,47 @@ export const FieldsUI = function () {
3737
const fields = meta?.fields ? JSON.parse( meta.fields ) : [];
3838
const blocks = meta?.blocks ? JSON.parse( meta.blocks ) : [];
3939

40+
const hasRegisteredAnyPostMeta = blocks.length > 0 || fields.length > 0;
41+
4042
return (
4143
<>
4244
<PluginDocumentSettingPanel
4345
name="create-content-model-field-settings"
4446
title={ __( 'Post Meta' ) }
4547
className="create-content-model-field-settings"
4648
>
47-
<ItemGroup isBordered isSeparated>
48-
{ blocks.length > 0 && (
49-
<>
50-
{ blocks.map( ( block ) => (
51-
<Item key={ block.uuid }>
52-
<Flex>
53-
<FlexItem>
54-
<Icon
55-
icon={ blockIcon( block.type ) }
56-
/>
57-
</FlexItem>
58-
<FlexBlock>{ block.label }</FlexBlock>
59-
<FlexItem>
60-
<code>{ block.slug }</code>
61-
</FlexItem>
62-
</Flex>
63-
</Item>
64-
) ) }
65-
</>
66-
) }
67-
{ fields.length > 0 && (
68-
<>
69-
{ fields.map( ( field ) => (
70-
<Item key={ field.uuid }>
71-
<Flex>
72-
<FlexItem>
73-
<Icon icon={ post } />
74-
</FlexItem>
75-
<FlexBlock>{ field.label }</FlexBlock>
76-
<FlexItem>
77-
<code>{ field.slug }</code>
78-
</FlexItem>
79-
</Flex>
80-
</Item>
81-
) ) }
82-
</>
83-
) }
84-
</ItemGroup>
49+
{ hasRegisteredAnyPostMeta && (
50+
<ItemGroup isBordered isSeparated>
51+
{ blocks.map( ( block ) => (
52+
<Item key={ block.uuid }>
53+
<Flex>
54+
<FlexItem>
55+
<Icon
56+
icon={ blockIcon( block.type ) }
57+
/>
58+
</FlexItem>
59+
<FlexBlock>{ block.label }</FlexBlock>
60+
<FlexItem>
61+
<code>{ block.slug }</code>
62+
</FlexItem>
63+
</Flex>
64+
</Item>
65+
) ) }
66+
{ fields.map( ( field ) => (
67+
<Item key={ field.uuid }>
68+
<Flex>
69+
<FlexItem>
70+
<Icon icon={ post } />
71+
</FlexItem>
72+
<FlexBlock>{ field.label }</FlexBlock>
73+
<FlexItem>
74+
<code>{ field.slug }</code>
75+
</FlexItem>
76+
</Flex>
77+
</Item>
78+
) ) }
79+
</ItemGroup>
80+
) }
8581

8682
<PanelRow>
8783
<Button

0 commit comments

Comments
 (0)