[Internal] ClientRetryPolicy: Adds Code to Apply Partition Level Override When a Requested Cancellation Token Expires #5063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kundadebdatta
changed the title
kundadebdatta
added
auto-merge
kundadebdatta
changed the title
…n_level_override_on_ct_expiry
kundadebdatta
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel,
kirillg and
Pilchie
as code owners
ananth7592
approved these changes
Mar 11, 2025
| this.failoverRetryCount, | ||
| this.locationEndpoint?.ToString() ?? string.Empty); | ||
|
|
||
| if (this.isPertitionLevelFailoverEnabled) |
There was a problem hiding this comment.
This is wrong - we did say that mark down shoudl only ever happen when you have a succesful operation against teh new write region, correct? Otherwise random timeouts could result in marking down the region?
There was a problem hiding this comment.
Thinking loud on this part, hedging on two regions when PPAF enabled for writes as alternative?
| this.documentServiceRequest); | ||
| } | ||
|
|
||
| return ShouldRetryResult.NoRetry(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Background:
During one of the backend drills, it was identified that when the following quorum loss condition is met, and the user provides a cancellation token, SDK honors the token, however doesn't apply the partition level fail over for the offending partition:
Observation:
Fix:
This PR is fixing the above behavior to apply partition level override, when a cancellation token gets expired.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #5060