-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core tools to emit warning if user is running .NET8 inproc app but without FUNCTIONS_INPROC_NET8_ENABLED
#4155
Comments
Is it possible to have core tools set |
Wherever it's auto-detected and set or a warning is emitted, do something. As of now, it's an extremely poor experience, and developers have no indication of what's going on and why there's a failure. |
I’ve been looking into resolving the confusion around launching .NET 8 inproc apps without having to set FUNCTIONS_INPROC_NET8_ENABLED manually and came across two promising approaches. Here’s a precise summary of each: Approach 1: csproj-Based Detection (PR #4248)
azure-functions-core-tools/src/Azure.Functions.Cli/Helpers/DotnetHelpers.cs Lines 208 to 211 in 1874ac4
Cons:
Approach 2: DLL-Based Detection (PR #4249) Detection is based on the compiled DLL, we will almost eliminate the edge cases (for example, multi-target scenarios are better handled). Cons:
Both approaches aim to streamline .NET 8 detection by automating the process. It would be valuable to discuss which approach fits best with our deployment scenarios and overall architecture. Looking forward to your thoughts on these options. |
I'd propose to repurpose this item slightly. Since .NET 6 is out of support, we should simply provide a warning whenever we aren't going down the .NET 8 path, with a pointer to instructions to migrate. That can include a warning about missing this setting. Draft proposed text (warning level):
|
@liliankasem @aishwaryabh we are already providing a warning when runtime is inproc8 Please find the screenshot below: We're displaying a warning currently—do you think it's adequate, or should we add more detail? |
Does this warning show when you run func start? Let's update the message to match what Matthew has drafted out above ^ |
Description
Today we require that local.settings.json has
"FUNCTIONS_INPROC_NET8_ENABLED": "1"
for a .NET8 inproc app. A lot of users get confused why the .NET 8 host doesn't launch when they are running an inproc .NET 8 app, so emitting a log/warning would be nice to let them know if they intend on running the .NET 8 host they should set the variable.The text was updated successfully, but these errors were encountered: