-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: support action group and metric linking #3643
Comments
Good suggestion. We'll look into doing this for the next release. Leaving |
To put specifics on this, the ActionGroupId should be labelled as an ARM ID. That's from this bit of Swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/monitor/resource-manager/Microsoft.Insights/stable/2018-03-01/metricAlert_API.json#L470 |
Could we make this fix in a nonbreaking way by overriding the JSON deserialize of the CrossResourceReference type? |
@theunrepentantgeek volunteered to see if we can fix this in a newer version. |
Unfortunately, version
We should revisit this suggestion from @matthchr |
Overriding deserialization of We have a potential design to fix this issue in #4543. |
Describe the current behavior
With the introduction of MetricAlert and ActionGroup resources, its not possible to "link" them as-is (through the references or configmap etc.) and user need to manually concatenate various parts to get the full armId value of the action group which would be subsequently parsed in MetricAlert resource.
Describe the improvement
It would be helpful if MetricAlert could support reference to the ActionGroup in the same namespace in addition to the full armId.
The text was updated successfully, but these errors were encountered: