Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: support action group and metric linking #3643

Open
t3mi opened this issue Dec 12, 2023 · 6 comments
Open

Improvement: support action group and metric linking #3643

t3mi opened this issue Dec 12, 2023 · 6 comments
Assignees
Labels
breaking A change which likely be breaking

Comments

@t3mi
Copy link
Contributor

t3mi commented Dec 12, 2023

Describe the current behavior
With the introduction of MetricAlert and ActionGroup resources, its not possible to "link" them as-is (through the references or configmap etc.) and user need to manually concatenate various parts to get the full armId value of the action group which would be subsequently parsed in MetricAlert resource.

Describe the improvement
It would be helpful if MetricAlert could support reference to the ActionGroup in the same namespace in addition to the full armId.

@theunrepentantgeek
Copy link
Member

Good suggestion. We'll look into doing this for the next release.

Leaving needs-triage so that we discuss this when we resume our weekly sync in the new year.

@matthchr
Copy link
Member

matthchr commented Jan 9, 2024

@matthchr
Copy link
Member

Could we make this fix in a nonbreaking way by overriding the JSON deserialize of the CrossResourceReference type?

@matthchr matthchr modified the milestones: v2.6.0, v2.7.0, v2.8.0 Feb 22, 2024
@theunrepentantgeek theunrepentantgeek modified the milestones: v2.8.0, v2.9.0 Apr 30, 2024
@theunrepentantgeek theunrepentantgeek added high-priority Issues we intend to prioritize (security, outage, blocking bug) breaking A change which likely be breaking labels Apr 30, 2024
@matthchr matthchr removed the high-priority Issues we intend to prioritize (security, outage, blocking bug) label Aug 22, 2024
@matthchr matthchr modified the milestones: v2.9.0, v2.10.0 Aug 22, 2024
@matthchr
Copy link
Member

@theunrepentantgeek volunteered to see if we can fix this in a newer version.

@theunrepentantgeek
Copy link
Member

Unfortunately, version 2018-03-01 is the most recent version of this particular resource, negating any possibility of using a version upgrade as an injection point for a silent upgrade.

Could we make this fix in a nonbreaking way by overriding the JSON deserialize of the CrossResourceReference type?

We should revisit this suggestion from @matthchr

@theunrepentantgeek theunrepentantgeek modified the milestones: v2.10.0, v2.11.0 Oct 14, 2024
@matthchr matthchr modified the milestones: v2.11.0, v2.12.0 Oct 28, 2024
@theunrepentantgeek
Copy link
Member

Overriding deserialization of genruntime.KnownResource won't help because we also change the property name - ActionGroupId becomes ActionGroupReference.

We have a potential design to fix this issue in #4543.

@theunrepentantgeek theunrepentantgeek moved this from Backlog to Up Next in Azure Service Operator Roadmap Feb 10, 2025
@theunrepentantgeek theunrepentantgeek removed this from the v2.12.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A change which likely be breaking
Projects
Development

No branches or pull requests

3 participants