Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder structure change for Microsoft.KubernetesConfiguration/* #4634

Open
arnaud-tincelin opened this issue Mar 17, 2025 · 2 comments
Open
Labels
question Further information is requested waiting-on-user-response Waiting on more information from the original user before progressing.

Comments

@arnaud-tincelin
Copy link

arnaud-tincelin commented Mar 17, 2025

We are trying to add the latest version, 2024-11-01, of Microsoft.KubernetesConfiguration/fluxConfigurations.

In previous versions, the path (from v2/specs/azure-rest-api-specs/specification/) was kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/stable/<version> but it has been changed to kubernetesConfiguration/resource-manager /Microsoft.KubernetesConfiguration/fluxConfigurations/stable/<version>

See azure-rest-api-specs

We are working on a PR and we are stuck. Any help would greatly appreciated :)
When trying to generate the code with the task command, we are having an error:

[controller:generate-types] 14:53:40 ERR failed to execute root command error="error generating code: failed to execute stage 21: Apply export filters to reduce the number of generated types: group kubernetesconfiguration: version 2024-11-01 not seen (did you mean 2022-11-01?): version 2024-11-01: $export specified for type FluxConfigurations but not consumed"
task: Failed to run task "default": exit status 1

with azure-arm.yaml:

kubernetesconfiguration:
    2024-11-01:
      FluxConfigurations:
        $export: true
        $supportedFrom: v2.13.0
@matthchr
Copy link
Member

Usually the generator tolerates directory restructures because it loads all types and then discovers everything. My guess is that this is related to a missing submodule update? Have you updated the embedded submodule of the azure-rest-api-specs directory to a commit id that has the new API in it?

I just checked my local copy and it doesn't look like I see that new directory structure yet. We talk about how to solve this here

@matthchr matthchr added the question Further information is requested label Mar 17, 2025
@matthchr
Copy link
Member

Also see --debug option of the generator which can also be useful sometimes (though in this case I don't think it's really needed, I believe it will be the submodule issue discussed above).

@matthchr matthchr added waiting-on-user-response Waiting on more information from the original user before progressing. and removed needs-triage 🔍 labels Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested waiting-on-user-response Waiting on more information from the original user before progressing.
Projects
Development

No branches or pull requests

2 participants