Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVM Module Issue]: Add customProperties to avm/res/insights/scheduled-query-rule #4708

Open
1 task done
Grant-Rc opened this issue Mar 11, 2025 · 3 comments · May be fixed by #4718
Open
1 task done

[AVM Module Issue]: Add customProperties to avm/res/insights/scheduled-query-rule #4708

Grant-Rc opened this issue Mar 11, 2025 · 3 comments · May be fixed by #4718
Assignees
@AlexanderSehr
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@Grant-Rc
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/insights/scheduled-query-rule

(Optional) Module Version

No response

Description

I was wanting to add a Custom Property to the modules and found that on line 131 the property does not have a definable property parameter

customProperties: {}

This would require a new Parameter say

@description('Optional. Advanced options for applying custom properties.')
param customProperties object = {}

...

actions: {
  actionGroups: actions
  customProperties: customProperties 
}

Is this something that can be added?

(Optional) Correlation Id

No response
@Grant-Rc Grant-Rc added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 11, 2025
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Mar 11, 2025
@avm-team-linter AVM Team Linter
Copy link

@Grant-Rc, thanks for submitting this issue for the avm/res/insights/scheduled-query-rule module!

Important

Please note, that this module is currently orphaned. The @Azure/avm-core-team-technical-bicep, will attempt to find an owner for it. In the meantime, the core team may assist with this issue. Thank you for your patience!

@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Mar 11, 2025
@AlexanderSehr
Copy link
Contributor

Hey @Grant-Rc,
that can certainly be done and sounds like a quick improvment. I'll try to sneak it in as soon as I can (which isn't exactly a committment, but bare with me).

@AlexanderSehr AlexanderSehr self-assigned this Mar 12, 2025
@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Mar 12, 2025
@AlexanderSehr AlexanderSehr changed the title [AVM Module Issue]: avm res insights scheduled-query-rule main.bicep [AVM Module Issue]: Add customProperties to avm/res/insights/scheduled-query-rule Mar 12, 2025
@AlexanderSehr AlexanderSehr linked a pull request Mar 12, 2025 that will close this issue
Draft
11 tasks
@AlexanderSehr
Copy link
Contributor

Hey @Grant-Rc,
I've pretty much finished the implementation but am struggling a bit with updating the test as I'd like to actually make sure the max test deploys an action group and passes parameters to it.
I'm stuggling a bit with deploying the action group in a way so that I can actually pass a custom/action property to it, as seen in the failed workflow run. Also looking at the actionGroup resource module tests did not really help.

By any chance: Would you have an example for an action group deployment with dynamic parameters defined that I could then pass values to in the scheduled query rule deployment?

Not exactly a resource I'm too familiar with. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexanderSehr AlexanderSehr

Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
AVM - Module Issues
Status: Needs: Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Insights/scheduledQueryRule - Added missing properties Azure/bicep-registry-modules
2 participants
@Grant-Rc @AlexanderSehr