Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVM Module Issue]: Deployment failure with VMSS when using Uniform orchestration mode #2088

Closed
1 task done
attbusmolgroup opened this issue May 29, 2024 · 10 comments · Fixed by #4739
Closed
1 task done

[AVM Module Issue]: Deployment failure with VMSS when using Uniform orchestration mode #2088

attbusmolgroup opened this issue May 29, 2024 · 10 comments · Fixed by #4739
Assignees
@rahalan
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@attbusmolgroup
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/compute/virtual-machine-scale-set

(Optional) Module Version

No response

Description

When setting Orchestration mode to Uniform, the NetworkApiVersion is still used even though the ternary says its null:

networkApiVersion: (orchestrationMode == 'Flexible') ? '2020-11-01' : null

In order to make it work with Uniform, the whole property needs to be commented out, or else the deployment fails:

Could not find member 'networkApiVersion' on object of type 'VMScaleSetNetworkProfile'. Path 'Properties.UpdateGroups[0].NetworkProfile.networkApiVersion', line 1, position 976. (Code: InvalidJson)

Changing the null to empty string also does not solves the issue.
It seems that if the property is used

(Optional) Correlation Id

No response
@attbusmolgroup attbusmolgroup added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels May 29, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Note

This label was added as per ITA06.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label May 29, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Note

The "Type: Bug 🐛" label was added as per ITA21.

@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label May 29, 2024
@avm-team-linter AVM Team Linter
Copy link

@attbusmolgroup, thanks for submitting this issue for the avm/res/compute/virtual-machine-scale-set module!

Important

A member of the @Azure/avm-res-compute-virtualmachinescaleset-module-owners-bicep or @Azure/avm-res-compute-virtualmachinescaleset-module-contributors-bicep team will review it soon!

@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues May 29, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Note

This message was posted as per ITA01BCP.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Jun 4, 2024
@rahalan rahalan removed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Jun 4, 2024
@rahalan
Copy link
Contributor

rahalan commented Jun 4, 2024

@attbusmolgroup thanks for bringing that up. I will look into it

@rahalan rahalan moved this from Needs: Triage to In Active Discussion in AVM - Module Issues Jun 13, 2024
@rahalan
Copy link
Contributor

rahalan commented Jun 24, 2024

@attbusmolgroup I was able to reproduce it. Seems like a bug in the resource provider. I will file a bug

@rahalan rahalan mentioned this issue Jul 11, 2024
Open
1 task
@mav108
Copy link

mav108 commented Aug 1, 2024 •
edited
Loading

Do we have any idea when will this get fixed?

@iskander-el-baraka
Copy link

iskander-el-baraka commented Aug 6, 2024 •
edited
Loading

Personally loving this bug.

OrchestrationMode: 'Uniform' is bugged.
OrchestrationMode: 'Flexible' doesnt support the use of system assigned managed identities.

Therefore cant use the avm for the creation of devops scale sets.

@KLuuKer
Copy link

KLuuKer commented Dec 10, 2024 •
edited
Loading

@rahalan this is blocking us in a major way

@rahalan rahalan mentioned this issue Mar 14, 2025
Merged
11 tasks
@rahalan
Copy link
Contributor

rahalan commented Mar 14, 2025

@KLuuKer will be fixed with PR #4739

@github-project-automation github-project-automation bot moved this from In Active Discussion to Done in AVM - Module Issues Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahalan rahalan

Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
AVM - Module Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Enable deployment of VMSS in uniform mode rahalan/bicep-registry-modules
5 participants
@KLuuKer @rahalan @mav108 @iskander-el-baraka @attbusmolgroup