Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValidationParameters Inconsistencies #3173

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

omidmloo
Copy link

Fix ValidationParameters Inconsistencies

Summary

This PR fixes inconsistencies in ValidationParameters by ensuring properties are copied correctly from TokenValidationParameters.

Description

  • The TryAllIssuerSigningKeys property was not being copied in the ValidationParameters(ValidationParameters other) constructor.
    • Fix: Now properly copies TryAllIssuerSigningKeys.
    • Behavior Change: In the new model, TryAllIssuerSigningKeys was false by default, whereas it was true in the current model. This has been aligned accordingly.
    • Fix: Updated ValidateActor in ValidationParameters for consistency.

Fixes #3131

@omidmloo omidmloo requested a review from a team as a code owner March 13, 2025 06:33
@@ -530,6 +531,7 @@ public TokenReplayValidationDelegate TokenReplayValidator
/// all available keys will be tried.
/// </summary>
/// <remarks>Default is false.</remarks>
[DefaultValue(true)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be set in the empty constructor.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the new validation model, ValidationParameters differs from TokenValidationParameters.
2 participants