Fix XML Equality Check by Comparing Parsed XML Structure Instead of Raw Strings #3166
+113
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix XML Equality Check by Comparing Parsed XML Structure Instead of Raw Strings
Summary of the changes
Ensures XML comparisons are based on structure instead of raw string equality.
Description
Previously, the test compared XML as raw strings, which caused false negatives due to formatting differences, whitespace, and attribute order. While the expected result was different, the discrepancies were due to formatting rather than actual content differences. This fix ensures XML elements are compared meaningfully, preventing incorrect failures.
Fixes & Improvements:
AreXmlsEqual
to handle XML documents as objects rather than raw strings.Fixes #3159