Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the new validation model, ValidationParameters differs from TokenValidationParameters. #3131

Open
pmaytak opened this issue Feb 13, 2025 · 2 comments · May be fixed by #3173
Open

In the new validation model, ValidationParameters differs from TokenValidationParameters. #3131

pmaytak opened this issue Feb 13, 2025 · 2 comments · May be fixed by #3173
Labels
Enhancement The issue is a new feature Good First Issue This is a good item for new team members Internal Indicates issue was opened by the IdentityModel team

Comments

@pmaytak
Copy link
Contributor

pmaytak commented Feb 13, 2025

-Need to fix:

  • In the ValidationParameters(ValidationParameters other), the value of TryAllIssuerSigningKeys is not copied over.
  • Also in the new model TryAllIssuerSigningKeys is false by default, but true by default in the current model.
  • Verify that there are no other missed differences between ValidationParameters and TokenValidationParameters.
    Note: some differences are intended, like there's no TokenDecryptionKey property, only the TokenDecryptionKeys collection.
@pmaytak pmaytak added Enhancement The issue is a new feature Good First Issue This is a good item for new team members Internal Indicates issue was opened by the IdentityModel team labels Feb 13, 2025
@omidmloo
Copy link

omidmloo commented Mar 2, 2025 •
edited
Loading

Hi there @pmaytak ,
I’d like to work on this issue. I have reviewed the code and resolved it.

While reviewing, I also noticed another property, ValidateActor, which has a DefaultValue attribute set to false in TokenValidationParameter but does not have a default value in ValidationParameter. Since the default value for a boolean is false, this should not cause any issues.

Would you like me to update it for consistency?

@pmaytak
Copy link
Contributor Author

pmaytak commented Mar 13, 2025

@omidmloo Thank you. Yes, I think let's update for consistency.

omidmloo added a commit to omidmloo/azure-activedirectory-identitymodel-extensions-for-dotnet that referenced this issue Mar 13, 2025
@omidmloo
fix differences between ValidationParameters and TokenValidationParam…
aabf2e9 
…eters AzureAD#3131
@omidmloo omidmloo linked a pull request Mar 13, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement The issue is a new feature Good First Issue This is a good item for new team members Internal Indicates issue was opened by the IdentityModel team
Projects
None yet
Milestone
No milestone
2 participants
@pmaytak @omidmloo