Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall we expose configurable key in KeychainPersistence on OSX? #130

Closed
mattmshell opened this issue Apr 26, 2024 · 1 comment
Closed

Shall we expose configurable key in KeychainPersistence on OSX? #130

mattmshell opened this issue Apr 26, 2024 · 1 comment
Labels
wontfix This will not be worked on

Comments

@mattmshell
Copy link

mattmshell commented Apr 26, 2024

build_encrypted_persistence doesn't provide sufficient control over the key name which leads to confusion. The value 'msal-extensions' is hardcoded in KeychainPersistence:

image
@rayluo
Copy link
Contributor

rayluo commented Aug 2, 2024

The build_encrypted_persistence() was meant to be a cross-platform helper so it contains no platform-specific parameters. Besides, the value "msal-extensions" was just a default value; it is customizable. You could copy build_encrypted_persistence()'s implementation and change the way it initializes KeychainPersistence.

@rayluo rayluo changed the title Explose configurable key in KeychainPersistence on OSX Shall we expose configurable key in KeychainPersistence on OSX? Aug 6, 2024
@rayluo rayluo added the wontfix This will not be worked on label Aug 6, 2024
@rayluo rayluo closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants