Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please use NS_ERROR_ENUM macro for describing errors #915

Open
Cy-4AH opened this issue Apr 22, 2020 · 1 comment
Open

Please use NS_ERROR_ENUM macro for describing errors #915

Cy-4AH opened this issue Apr 22, 2020 · 1 comment
Labels

Comments

@Cy-4AH
Copy link

Cy-4AH commented Apr 22, 2020

typedef NS_ENUM(NSInteger, MSALError)

Wrong macro complicates error handling in swift:
for example can't use statement:
catch MSALError.interactionRequired
it's leads to error message: Cast from 'Error' to unrelated type 'MSALError' always fails

@mipetriu
Copy link
Contributor

@Cy-4AH Thanks for your suggestion, we have to determine if making this change will cause any problems. We will update this with more details later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants