Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker v3 protocol requires MSAL version, but not MSAL name #950

Open
bgavrilMS opened this issue Jun 10, 2020 · 1 comment
Open

Broker v3 protocol requires MSAL version, but not MSAL name #950

bgavrilMS opened this issue Jun 10, 2020 · 1 comment
Labels

Comments

@bgavrilMS
Copy link
Member

The broker protocol requires us to pass in the version of MSAL. But there are 2 MSALs that call the iOS broker - MSAL.iOS and MSAL.NET via Xamarin. So we need a way to differentiate between the 2, easiest is to log the client SKU.

Impact: small impact, but this improvement would make supportability easier, as you'd be able to see who called the broker directly from the logs.

@oldalton
Copy link
Member

Verified that we always default to MSAL.iOS as the source library when request comes from MSAL. Agree that it's important to differentiate between MSAL.iOS, MSAL Xamarin and MSAL CPP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants