Fix color affectation when dealing with color3 component (#16259)

Co-authored-by: David Catuhe <[email protected]>

Author: deltakosh

.build/config.json

@@ -1,5 +1,5 @@
 {
-  "versionDefinition": "patch",
-  "preid": "rc",
-  "nonce": 335
-}
+    "versionDefinition": "patch",
+    "preid": "rc",
+    "nonce": 336
+}

packages/dev/core/src/Meshes/geometry.ts

@@ -1042,21 +1042,27 @@ export class Geometry implements IGetSetVerticesData {
         let stopChecking = false;
         let kind;
         for (kind in this._vertexBuffers) {
-            this.copyVerticesData(kind, vertexData as any);
+            const data = this.getVerticesData(kind);
+            if (data) {
+                if (data instanceof Float32Array) {
+                    vertexData.set(new Float32Array(<Float32Array>data), kind);
+                } else {
+                    vertexData.set((<number[]>data).slice(0), kind);
+                }
 
-            if (!stopChecking) {
-                const vb = this.getVertexBuffer(kind);
+                if (!stopChecking) {
+                    const vb = this.getVertexBuffer(kind);
 
-                if (vb) {
-                    updatable = vb.isUpdatable();
-                    stopChecking = !updatable;
+                    if (vb) {
+                        updatable = vb.isUpdatable();
+                        stopChecking = !updatable;
+                    }
                 }
             }
         }
 
         const geometry = new Geometry(id, this._scene, vertexData, updatable);
 
-        geometry._totalVertices = this._totalVertices;
         geometry.delayLoadState = this.delayLoadState;
         geometry.delayLoadingFile = this.delayLoadingFile;
         geometry._delayLoadingFunction = this._delayLoadingFunction;

packages/dev/core/src/Meshes/mesh.vertexData.ts

@@ -50,7 +50,7 @@ export interface IGetSetVerticesData {
      * @param updatable defines if the vertex must be flagged as updatable (false as default)
      * @param stride defines the stride to use (0 by default). This value is deduced from the kind value if not specified
      */
-    setVerticesData(kind: string, data: FloatArray, updatable: boolean): void;
+    setVerticesData(kind: string, data: FloatArray, updatable: boolean, stride?: number): void;
     /**
      * Update a specific associated vertex buffer
      * @param kind defines which buffer to write to (positions, indices, normals, etc). Possible `kind` values :
@@ -470,7 +470,8 @@ export class VertexData implements IVertexDataLike {
         }
 
         if (this.colors) {
-            meshOrGeometry.setVerticesData(VertexBuffer.ColorKind, this.colors, updatable);
+            const stride = this.positions && this.colors.length === this.positions!.length ? 3 : 4;
+            meshOrGeometry.setVerticesData(VertexBuffer.ColorKind, this.colors, updatable, stride);
             if (this.hasVertexAlpha && (meshOrGeometry as any).hasVertexAlpha !== undefined) {
                 (meshOrGeometry as any).hasVertexAlpha = true;
             }