apacheGH-39259: [JS] Remove getByteLength (apache#39260)

* Closes: apache#39259

Author: domoritz

js/src/recordbatch.ts

@@ -25,7 +25,6 @@ import { instance as getVisitor } from './visitor/get.js';
 import { instance as setVisitor } from './visitor/set.js';
 import { instance as indexOfVisitor } from './visitor/indexof.js';
 import { instance as iteratorVisitor } from './visitor/iterator.js';
-import { instance as byteLengthVisitor } from './visitor/bytelength.js';
 
 /** @ignore */
 export interface RecordBatch<T extends TypeMap = any> {
@@ -150,14 +149,6 @@ export class RecordBatch<T extends TypeMap = any> {
         return indexOfVisitor.visit(this.data, element, offset);
     }
 
-    /**
-     * Get the size (in bytes) of a row by index.
-     * @param index The row index for which to compute the byteLength.
-     */
-    public getByteLength(index: number): number {
-        return byteLengthVisitor.visit(this.data, index);
-    }
-
     /**
      * Iterator for rows in this RecordBatch.
      */

js/src/table.ts

@@ -38,7 +38,6 @@ import { instance as getVisitor } from './visitor/get.js';
 import { instance as setVisitor } from './visitor/set.js';
 import { instance as indexOfVisitor } from './visitor/indexof.js';
 import { instance as iteratorVisitor } from './visitor/iterator.js';
-import { instance as byteLengthVisitor } from './visitor/bytelength.js';
 
 import { DataProps } from './data.js';
 import { clampRange } from './util/vector.js';
@@ -215,13 +214,6 @@ export class Table<T extends TypeMap = any> {
     // @ts-ignore
     public indexOf(element: Struct<T>['TValue'], offset?: number): number { return -1; }
 
-    /**
-     * Get the size in bytes of an element by index.
-     * @param index The index at which to get the byteLength.
-     */
-    // @ts-ignore
-    public getByteLength(index: number): number { return 0; }
-
     /**
      * Iterator for rows in this Table.
      */
@@ -390,7 +382,6 @@ export class Table<T extends TypeMap = any> {
         (proto as any)['get'] = wrapChunkedCall1(getVisitor.getVisitFn(Type.Struct));
         (proto as any)['set'] = wrapChunkedCall2(setVisitor.getVisitFn(Type.Struct));
         (proto as any)['indexOf'] = wrapChunkedIndexOf(indexOfVisitor.getVisitFn(Type.Struct));
-        (proto as any)['getByteLength'] = wrapChunkedCall1(byteLengthVisitor.getVisitFn(Type.Struct));
         return 'Table';
     })(Table.prototype);
 }

js/src/vector.ts

@@ -36,7 +36,6 @@ import { instance as getVisitor } from './visitor/get.js';
 import { instance as setVisitor } from './visitor/set.js';
 import { instance as indexOfVisitor } from './visitor/indexof.js';
 import { instance as iteratorVisitor } from './visitor/iterator.js';
-import { instance as byteLengthVisitor } from './visitor/bytelength.js';
 
 // @ts-ignore
 import type { vectorFromArray } from './factories.js';
@@ -56,7 +55,7 @@ export interface Vector<T extends DataType = any> {
     [Symbol.isConcatSpreadable]: true;
 }
 
-const visitorsByTypeId = {} as { [typeId: number]: { get: any; set: any; indexOf: any; byteLength: any } };
+const visitorsByTypeId = {} as { [typeId: number]: { get: any; set: any; indexOf: any } };
 const vectorPrototypesByTypeId = {} as { [typeId: number]: any };
 
 /**
@@ -76,14 +75,13 @@ export class Vector<T extends DataType = any> {
             case 0: this._offsets = [0]; break;
             case 1: {
                 // special case for unchunked vectors
-                const { get, set, indexOf, byteLength } = visitorsByTypeId[type.typeId];
+                const { get, set, indexOf } = visitorsByTypeId[type.typeId];
                 const unchunkedData = data[0];
 
                 this.isValid = (index: number) => isChunkedValid(unchunkedData, index);
                 this.get = (index: number) => get(unchunkedData, index);
                 this.set = (index: number, value: T) => set(unchunkedData, index, value);
                 this.indexOf = (index: number) => indexOf(unchunkedData, index);
-                this.getByteLength = (index: number) => byteLength(unchunkedData, index);
                 this._offsets = [0, unchunkedData.length];
                 break;
             }
@@ -200,13 +198,6 @@ export class Vector<T extends DataType = any> {
         return this.indexOf(element, offset) > -1;
     }
 
-    /**
-     * Get the size in bytes of an element by index.
-     * @param index The index at which to get the byteLength.
-     */
-    // @ts-ignore
-    public getByteLength(index: number): number { return 0; }
-
     /**
      * Iterator for the Vector's elements.
      */
@@ -366,15 +357,13 @@ export class Vector<T extends DataType = any> {
             const get = getVisitor.getVisitFnByTypeId(typeId);
             const set = setVisitor.getVisitFnByTypeId(typeId);
             const indexOf = indexOfVisitor.getVisitFnByTypeId(typeId);
-            const byteLength = byteLengthVisitor.getVisitFnByTypeId(typeId);
 
-            visitorsByTypeId[typeId] = { get, set, indexOf, byteLength };
+            visitorsByTypeId[typeId] = { get, set, indexOf };
             vectorPrototypesByTypeId[typeId] = Object.create(proto, {
                 ['isValid']: { value: wrapChunkedCall1(isChunkedValid) },
                 ['get']: { value: wrapChunkedCall1(getVisitor.getVisitFnByTypeId(typeId)) },
                 ['set']: { value: wrapChunkedCall2(setVisitor.getVisitFnByTypeId(typeId)) },
                 ['indexOf']: { value: wrapChunkedIndexOf(indexOfVisitor.getVisitFnByTypeId(typeId)) },
-                ['getByteLength']: { value: wrapChunkedCall1(byteLengthVisitor.getVisitFnByTypeId(typeId)) },
             });
         }
 

js/src/visitor/bytelength.ts

@@ -369,13 +369,6 @@ describe(`Table`, () => {
                     }
                 }
             });
-
-            test(`table.getByteLength() returns the byteLength of each row`, () => {
-                const table = datum.table();
-                for (let i = -1, n = table.numRows; ++i < n;) {
-                    expect(table.getByteLength(i)).toBeGreaterThan(0);
-                }
-            });
         });
     }
 });