DEBUGGED

Author: Bl4ck-C4t

cows and bulls.py

@@ -1,4 +1,18 @@
 import random
+def cow_find(it1,it2):
+    c = 0
+    for x in it1:
+        for y in range(len(it2)):
+            if x == it2[y] and it2[y] != it1[y]:
+                c += 1
+    return c
+def bull_find(it1,it2):
+    bulls = 0
+    c = list(zip(it1,it2))
+    for x,y in c:
+        if x == y:
+            bulls += 1
+    return bulls
 ln = int(input("Enter secret number's length: "))
 attempts = int(input("Enter attempts: "))
 rep = input("Do you want to have same digits in the secret number?(y/n): ")
@@ -10,6 +24,7 @@
     while len(str(num)) != len(set(str(num))):
         num = random.randint(n1,n2)
 print("The number is " + str(len(str(num))) + " digits long.")
+num = 1231
 guess = ""
 nm = str(num)
 pl = True
@@ -27,15 +42,11 @@
     guess = int(input("Enter number: "))
     if guess == -1:
         print(num)
+        attempts += 1
+        continue
     gs = str(guess)
-    c = list(zip(nm,gs))
-    for x,y in c:
-        if x == y:
-            bulls += 1
-    for z in gs:
-        times = nm.count(z)
-        cows += times
-    cows -= bulls
+    bulls += bull_find(gs,nm)
+    cows += cow_find(gs,nm)
     print("Bulls: " + str(bulls))
     print("Cows: " + str(cows))
     attempts -= 1
@@ -48,6 +59,6 @@
         player = "Player 2"
     print("The number was {}. {} won!!".format(num,player))
     print("You won in {} attempts".format(att-attempts))
-    if att - attempts <= 4:
+    if att - attempts <= att/2:
         print("Wow that luck/cheat brah!!!")
 input("Press any key to exit...")