Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align cancel samples methods #4179

Open
3 tasks
islean opened this issue Feb 5, 2025 · 0 comments
Open
3 tasks

Align cancel samples methods #4179

islean opened this issue Feb 5, 2025 · 0 comments

Comments

@islean
Copy link
Contributor

islean commented Feb 5, 2025

As a user of our web interface StatusDB,
I want the 'cancel samples' button and toggling the 'is_cancelled' field in the sample table to do the same thing,
So that I do not accidentally do something unintended.

Work impact

Answer the following questions:

  • Is there currently a workaround for this issue? If so, what is it?
    • NA
  • How much time would be saved by implementing this feature on a weekly basis?
    • NA
  • How many users are affected by this issue?
    • All production members cancelling samples
  • Are customers affected by this issue?
    • If issues happen

Acceptance Criteria

  • Criteria 1
  • Criteria 2
  • Criteria 3
    ...

Notes

The button "cancel samples" currently does a few things:

  1. It toggles the is_cancelled values on the selected samples
  2. It removes any CaseSample entries for the selected samples
  3. It adds a comment to the samples stating who cancelled them
  4. It deletes any cases which are not tied to any sample after their cancellation

Toggling the is_cancelled value in the table only does step 1, but seemingly should do the same. Otherwise we maybe should rename something so that they are not semantically identical but in reality quite different.

We should probably add a little popup with a tool tip describing what the buttons do as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant