-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Server Syntax Highlights #1985
Open
thecoolwinter
wants to merge
22
commits into
CodeEditApp:main
Choose a base branch
from
thecoolwinter:feat/lsp-semantic-highlighter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Language Server Syntax Highlights #1985
thecoolwinter
wants to merge
22
commits into
CodeEditApp:main
from
thecoolwinter:feat/lsp-semantic-highlighter
+902
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecoolwinter/CodeEdit into feat/lsp-semantic-highlighter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
language server
Issues or Pull Requests related to language servers.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds semantic token syntax highlighting to the code file view.
When an LSP is installed and configured for a language type, and has semantic highlights support, CodeEdit will install a new highlight provider on the source editor and begin processing syntax tokens for the file.
Token processing happens asynchronously, and does not replace tree-sitter highlights. This builds off recent work in the source editor to support a hierarchy of highlight providers. Language server highlights are slow but more accurate, so we process them slowly and apply them when they become available.
Details
CodeFileDocument
, it'll be a matter of conforming the new type to the protocol for it to work with the lsp code.SemanticTokenHighlightProvider
typeHighlightProviding
protocol.SemanticTokenMap
typeSemanticTokenStorage
Related Issues
Checklist
Screenshots
Live editing demo, note the highlights on the variable types and switch cases.
CodeEdit.mp4