-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can't use internals for public API #1192
Labels
enhancement
New feature or request
Comments
@Frozen-byte this issue is caused by https://github.com/CycloneDX/cyclonedx-webpack-plugin/pull/1338/files#r1867685873
|
i will be working on a non-breaking solution. |
as the previous API was non-public, a change to use some public API is considered non-breaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
some properties and constructor parameters use internal types, like
SortableStringables
.this is an issue, as these internals are not exported. they can not be used downstream.
It prevents usage like follows:
context
some symbols are mark as internals, they are not exported, and they are not public API.
see https://cyclonedx-javascript-library.readthedocs.io/en/latest/typedoc/node/modules/_internal_.html
but yet, some internals are used in public API, as properties or parameters.
requirements / goals
They miught be used for inheritance, still.
solution
have dedicated classes, that are properly exported and public API.
for example
just like we did before:
cyclonedx-javascript-library/src/enums/vulnerability/analysisResponse.ts
Line 30 in fca1db5
considerations
since this would change types of public API, we would introduce it in a two-staged manner:
ComponentEvidence(..., copyright: CopyrightRepository|SortableStringables)
copyright: SortableStringables
prepare a breaking change, but dont mere it yet; have it added to the next major milestone.
see must not use internals for public API #1193
The text was updated successfully, but these errors were encountered: