add tests validating service version and required links

Author: fmigneault

node_registry.schema.json

@@ -126,7 +126,7 @@
         "properties": {
           "rel": {
             "type": "string",
-            "const": "service"
+            "const": "service-doc"
           }
         }
       }

tests/test_registry.py

@@ -1,3 +1,4 @@
+import copy
 import os
 
 import json
@@ -26,6 +27,33 @@ def registry_content(request):
     return content
 
 
+@pytest.fixture
+def registry_content_with_services(registry_content):
+    any_svc_key = list(registry_content)[0]
+    registry_content["test"] = copy.deepcopy(registry_content[any_svc_key])
+    registry_content["test"]["services"] = [
+        {
+            "name": "test-service",
+            "keywords": ["other"],
+            "description": "test service",
+            "version": "1.2.3",
+            "links": [
+                {
+                    "rel": "service",
+                    "href": "https://example.com/test",
+                    "type": "application/json"
+                },
+                {
+                    "rel": "service-doc",
+                    "href": "https://readthedocs.com/example",
+                    "type": "text/html"
+                }
+            ]
+        }
+    ]
+    return registry_content
+
+
 @pytest.fixture
 def schema_content(request):
     """Return the content contained in node_registry.schema.json"""
@@ -38,3 +66,43 @@ def schema_content(request):
 
 def test_valid_registry(registry_content, schema_content):
     jsonschema.validate(registry_content, schema_content)
+
+
+def test_services_good_version(registry_content_with_services, schema_content):
+    jsonschema.validate(registry_content_with_services, schema_content)
+
+
+def test_services_bad_version(registry_content_with_services, schema_content):
+    registry_content_with_services["test"]["services"][0]["version"] = "bad_version"
+    with pytest.raises(jsonschema.exceptions.ValidationError) as exc:
+        jsonschema.validate(registry_content_with_services, schema_content)
+    assert "bad_version" in exc.value.message
+    assert list(exc.value.path) == ["test", "services", 0, "version"]
+    assert list(exc.value.schema_path)[-6:] == ["properties", "services", "items", "properties", "version", "pattern"]
+
+
+def test_services_bad_links(registry_content_with_services, schema_content):
+    registry_content_with_services["test"]["services"][0].pop("links")
+    with pytest.raises(jsonschema.exceptions.ValidationError) as exc:
+        jsonschema.validate(registry_content_with_services, schema_content)
+    assert exc.value.message == "'links' is a required property"
+    assert list(exc.value.path) == ["test", "services", 0]
+    assert list(exc.value.schema_path)[-4:] == ["properties", "services", "items", "required"]
+
+
+@pytest.mark.parametrize(
+    ["required_link_rel", "expected_link_pos"],
+    [
+        ("service", 0),
+        ("service-doc", 1),
+    ]
+)
+def test_services_missing_link(registry_content_with_services, schema_content, required_link_rel, expected_link_pos):
+    links = registry_content_with_services["test"]["services"][0]["links"]
+    links = [link for link in links if link["rel"] != required_link_rel]
+    registry_content_with_services["test"]["services"][0]["links"] = links
+    with pytest.raises(jsonschema.exceptions.ValidationError) as exc:
+        jsonschema.validate(registry_content_with_services, schema_content)
+    assert "does not contain" in exc.value.message
+    assert list(exc.value.path) == ["test", "services", 0, "links"]
+    assert list(exc.value.schema_path)[-4:] == ["links", "allOf", expected_link_pos, "contains"]