Skip to content

Commit 7d8d051

Browse files
committed
Fix DNR-breaking extension update bug
If we update to an extension version with a larger tracker database, and if we disabled PB on one or more sites, we run into a dynamic rule ID bookkeeping bug that causes tracker database DNR rule registration to fail entirely. We can avoid this bug by delaying all DNR rule updates until we are done resetting max ID as part of resetting tracker data.
1 parent 8ceed63 commit 7d8d051

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/js/background.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,10 @@ function Badger(from_qunit) {
138138
}
139139
});
140140

141+
await widgetListPromise;
142+
await seedDataPromise;
143+
await tabDataPromise;
144+
141145
if (self.isUpdate && self.manifestVersion > 2) {
142146
// TODO don't need to do disabled sites on every update, just the first one to MV3 ...
143147
let disabledSites = self.getDisabledSites();
@@ -153,10 +157,6 @@ function Badger(from_qunit) {
153157
}
154158
}
155159

156-
await widgetListPromise;
157-
await seedDataPromise;
158-
await tabDataPromise;
159-
160160
if (self.isFirstRun || self.isUpdate || !self.getPrivateSettings().getItem('doneLoadingSeed')) {
161161
// block all widget domains
162162
// only need to do this when the widget list could have gotten updated

0 commit comments

Comments
 (0)