You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
minor #6855 Upgrade to PHPStan 2.x (javiereguiluz)
This PR was squashed before being merged into the 4.x branch.
Discussion
----------
Upgrade to PHPStan 2.x
There are two issues that I can't fix, even with AI help:
https://github.com/EasyCorp/EasyAdminBundle/blob/4.x/src/Dto/EntityDto.php#L170-L171
```
------ ------------------------------------------------------------------------------------------------------------------------------------
Line Dto/EntityDto.php
------ ------------------------------------------------------------------------------------------------------------------------------------
175 PHPDoc tag `@var` with type array|Doctrine\ORM\Mapping\FieldMapping is not subtype of native type Doctrine\ORM\Mapping\FieldMapping.
🪪 varTag.nativeType
------ ------------------------------------------------------------------------------------------------------------------------------------
```
https://github.com/EasyCorp/EasyAdminBundle/blob/3473fcab8b485506e3f112728bc4d37f8089819a/src/Intl/IntlFormatter.php#L111-L112
```
------ -----------------------------------------------------------------------
Line Intl/IntlFormatter.php
------ -----------------------------------------------------------------------
112 PHPDoc tag `@var` with type string|false is not subtype of type string.
🪪 varTag.type
------ -----------------------------------------------------------------------
```
Commits
-------
044444e Upgrade to PHPStan 2.x
if (!\is_string($label) && !$labelinstanceof TranslatableInterface) {
172
172
thrownew \RuntimeException(sprintf('The callable used to define the label of the "%s" action label %s must return a string or a %s instance but it returned a(n) "%s" value instead.', $actionDto->getName(), null !== $entityDto ? 'in the "'.$entityDto->getName().'" entity' : '', TranslatableInterface::class, \gettype($label)));
Copy file name to clipboardexpand all lines: src/Twig/Component/Flag.php
+1-1
Original file line number
Diff line number
Diff line change
@@ -26,6 +26,6 @@ public function getFlagAsSvg(): string
26
26
returnsprintf('<svg xmlns="http://www.w3.org/2000/svg" class="country-flag" height="%d" viewBox="0 0 25 17"><title>You are not seeing a country flag here because the "%s.svg" file associated to given the "%s" country code does not exist in the assets/icons/flags/ directory of EasyAdmin.</title><rect width="100%%" height="%d" fill="#ff0000"/></svg>', $this->height, $this->countryCode, $this->countryCode, $this->height);
0 commit comments