Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./pwnlib/lexer.py: Undefined names in __all__ #1309

Open
cclauss opened this issue May 9, 2019 · 0 comments
Open

./pwnlib/lexer.py: Undefined names in __all__ #1309

cclauss opened this issue May 9, 2019 · 0 comments
Labels
code style good first issue Good if you want to help but you do not know the project well help-wanted

Comments

@cclauss
Copy link
Contributor

cclauss commented May 9, 2019

Pwntools Issue Template

Thanks for contributing to Pwntools!

When reporting an issue, be sure that you are running the latest released version of pwntools (pip install --upgrade pwntools).

Please verify that your issue occurs on 64-bit Ubuntu 14.04. You can use the Dockerfile on docker.io for quick testing.

$ docker pull pwntools/pwntools:stable
$ docker run -it pwntools/pwntools:stable

If possible, provide a proof-of-concept which demonstrates the problem. Include any binaries or scripts necessary to reproduce the issue, and please include the full debug output via setting the environment variable PWNLIB_DEBUG=1.


We are trying to export these variables in __all__ but they are not defined. Are we making promises that we cannot fulfill? Where are these variables defined?

flake8 testing of https://github.com/Gallopsled/pwntools on Python 2.7.15

$ flake8 . --count --select=F822 --show-source --statistics

./pwnlib/lexer.py:23:1: F822 undefined name 'LlvmLexer' in __all__
__all__ = ['GasLexer', 'ObjdumpLexer', 'DObjdumpLexer', 'CppObjdumpLexer',
^
./pwnlib/lexer.py:23:1: F822 undefined name 'CppObjdumpLexer' in __all__
__all__ = ['GasLexer', 'ObjdumpLexer', 'DObjdumpLexer', 'CppObjdumpLexer',
^
./pwnlib/lexer.py:23:1: F822 undefined name 'DObjdumpLexer' in __all__
__all__ = ['GasLexer', 'ObjdumpLexer', 'DObjdumpLexer', 'CppObjdumpLexer',
^
./pwnlib/lexer.py:23:1: F822 undefined name 'GasLexer' in __all__
__all__ = ['GasLexer', 'ObjdumpLexer', 'DObjdumpLexer', 'CppObjdumpLexer',
^
./pwnlib/lexer.py:23:1: F822 undefined name 'CObjdumpLexer' in __all__
__all__ = ['GasLexer', 'ObjdumpLexer', 'DObjdumpLexer', 'CppObjdumpLexer',
^
./pwnlib/lexer.py:23:1: F822 undefined name 'ObjdumpLexer' in __all__
__all__ = ['GasLexer', 'ObjdumpLexer', 'DObjdumpLexer', 'CppObjdumpLexer',
^
./pwnlib/lexer.py:23:1: F822 undefined name 'NasmLexer' in __all__
__all__ = ['GasLexer', 'ObjdumpLexer', 'DObjdumpLexer', 'CppObjdumpLexer',
^
./pwnlib/lexer.py:23:1: F822 undefined name 'NasmObjdumpLexer' in __all__
__all__ = ['GasLexer', 'ObjdumpLexer', 'DObjdumpLexer', 'CppObjdumpLexer',
^
./pwnlib/lexer.py:23:1: F822 undefined name 'Ca65Lexer' in __all__
__all__ = ['GasLexer', 'ObjdumpLexer', 'DObjdumpLexer', 'CppObjdumpLexer',
^
9     F822 undefined name 'LlvmLexer' in __all__

F822 is the "showstopper" flake8 issue that can halt the runtime with a NameError. This error is different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

  • F822: undefined name name in __all__
@Arusekk Arusekk added the good first issue Good if you want to help but you do not know the project well label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code style good first issue Good if you want to help but you do not know the project well help-wanted
Projects
None yet
Development

No branches or pull requests

3 participants