Skip to content

Commit 892443e

Browse files
Merge pull request #1938 from Giskard-AI/feature/filter_sentry_error_repporting
Remove noise by filtering error that arise outside of giskard (ei. in jupiter notebook)
2 parents fdd379c + c9bc030 commit 892443e

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

giskard/utils/sentry.py

+15-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import Dict
1+
from typing import Dict, Optional
22

33
import os
44
import re
@@ -61,7 +61,17 @@ def scrub_stacktrace(stacktrace):
6161
return stacktrace
6262

6363

64-
def scrub_event(event, _hint) -> Dict[str, ABC]:
64+
def has_giskard_module_in_frames(stacktrace):
65+
if "frames" not in stacktrace:
66+
return False
67+
68+
return any(
69+
"module" in frame and frame["module"] is not None and frame["module"].split(".")[0] == "giskard"
70+
for frame in stacktrace["frames"]
71+
)
72+
73+
74+
def scrub_event(event, _hint) -> Optional[Dict[str, ABC]]:
6575
if "exception" not in event:
6676
return event
6777

@@ -71,6 +81,9 @@ def scrub_event(event, _hint) -> Dict[str, ABC]:
7181

7282
for value in exception["values"]:
7383
if "stacktrace" in value:
84+
if not has_giskard_module_in_frames(value["stacktrace"]):
85+
return None # Remove noise by filtering error that arise outside of giskard (ei. in jupiter notebook)
86+
7487
value["stacktrace"] = scrub_stacktrace(value["stacktrace"])
7588

7689
return event

0 commit comments

Comments
 (0)