Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE]: GRM Create does not respect spaces in name #1497

Open
2 tasks done
mkevenaar opened this issue Feb 9, 2025 · 3 comments
Open
2 tasks done

[ISSUE]: GRM Create does not respect spaces in name #1497

mkevenaar opened this issue Feb 9, 2025 · 3 comments
Milestone

Comments

@mkevenaar
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have searched issues to ensure it has not already been reported

GitVersion package

GitHub Actions

What are you seeing?

I want to include a space in the release name when creating a release. e.g. ,"Release 0.3.0". The string isn't quoted so only the first word is used in the release name

https://github.com/mkevenaar/ObjectFirst.Zabbix/actions/runs/13227076634/job/36919281955#step:10:95

What is expected?

The name string to be quoted

Steps to Reproduce

Workflow
https://github.com/mkevenaar/ObjectFirst.Zabbix/blob/main/.github/workflows/release.yaml
Output
https://github.com/mkevenaar/ObjectFirst.Zabbix/actions/runs/13227076634/job/36919281955#step:10:95

Output log or link to your CI build (if appropriate).

: /opt/hostedtoolcache/GitReleaseManager.Tool/0.18.0/dotnet-gitreleasemanager --roll-forward Major create --owner mkevenaar --repository ObjectFirst.Zabbix --token *** --targetDirectory /home/runner/work/ObjectFirst.Zabbix/ObjectFirst.Zabbix --milestone 0.3.0 --name Release 0.3.0 --assets /home/runner/work/ObjectFirst.Zabbix/ObjectFirst.Zabbix/release.zip
@arturcic
Copy link
Member

arturcic commented Feb 9, 2025

I think this is

if (settings.name) {
what you are looking for. but I think that should an improvement on most (if not all) of the parameters we pass to both GRM and GV. Are you considering a PR?

@mkevenaar
Copy link
Author

@arturcic I have never worked on any GHA projects, and I am in the middle of working on other projects. I won't have time till after April before I can even attempt to take a stab at it.

@arturcic
Copy link
Member

arturcic commented Feb 9, 2025

Gotcha, I will see when/if I have time for this one, otherwise you need to use underscores or similar for now

@arturcic arturcic added this to the v3.x milestone Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants