Skip to content

Commit 7a3c7f7

Browse files
linghengqianInvisibleProgrammer
authored andcommitted
HIVE-28417: Bump Log4j2 to 2.24.1 to facilitate compilation of GraalVM Native Image (apache#5375)(Ling Hengqian, reviewed by Raghav Aggarwal, Butao Zhang)
(cherry picked from commit 548990d)
1 parent da272b4 commit 7a3c7f7

File tree

8 files changed

+15
-20
lines changed

8 files changed

+15
-20
lines changed

data/conf/hive-log4j2.properties

+1-9
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
status = INFO
1817
name = HiveLog4j2Test
19-
packages = org.apache.hadoop.hive.ql.log
2018

2119
# list of properties
2220
property.hive.log.level = DEBUG
@@ -25,9 +23,6 @@ property.hive.log.dir = ${sys:test.tmp.dir}/log
2523
property.hive.log.file = hive.log
2624
property.hive.test.console.log.level = INFO
2725

28-
# list of all appenders
29-
appenders = console, DRFA
30-
3126
# console appender
3227
appender.console.type = Console
3328
appender.console.name = console
@@ -49,9 +44,6 @@ appender.DRFA.policies.time.modulate = true
4944
appender.DRFA.strategy.type = DefaultRolloverStrategy
5045
appender.DRFA.strategy.max = 30
5146

52-
# list of all loggers
53-
loggers = HadoopIPC, HadoopSecurity, Hdfs, HdfsServer, HadoopMetrics2, Mortbay, Yarn, YarnServer, Tez, HadoopConf, Zookeeper, ServerCnxn, NIOServerCnxn, ClientCnxn, ClientCnxnSocket, ClientCnxnSocketNIO, DataNucleus, Datastore, JPOX, Operator, Serde2Lazy, ObjectStore, CalcitePlanner, AmazonAws, ApacheHttp, Thrift, Jetty, BlockStateChange, swo, CBORuleLogger
54-
5547
logger.HadoopIPC.name = org.apache.hadoop.ipc
5648
logger.HadoopIPC.level = WARN
5749

@@ -128,7 +120,7 @@ logger.CBORuleLogger.filter.marker.type = MarkerFilter
128120
logger.CBORuleLogger.filter.marker.marker = FULL_PLAN
129121
# Change filter to ACCEPT, to see the produced plan after every rule invocation using the EXPLAIN CBO format
130122
logger.CBORuleLogger.filter.marker.onMatch = DENY
131-
logger.CBORuleLogger.filter.marker.onMisMatch = NEUTRAL
123+
logger.CBORuleLogger.filter.marker.onMismatch = NEUTRAL
132124

133125
logger.AmazonAws.name=com.amazonaws
134126
logger.AmazonAws.level = INFO

llap-server/pom.xml

+1-2
Original file line numberDiff line numberDiff line change
@@ -367,9 +367,8 @@
367367
</dependency>
368368
<dependency>
369369
<groupId>org.apache.logging.log4j</groupId>
370-
<artifactId>log4j-core</artifactId>
370+
<artifactId>log4j-core-test</artifactId>
371371
<version>${log4j2.version}</version>
372-
<classifier>tests</classifier>
373372
<scope>test</scope>
374373
<exclusions>
375374
<exclusion>

llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,9 @@
4848
import org.apache.tez.common.security.TokenCache;
4949
import org.slf4j.Logger;
5050
import org.slf4j.LoggerFactory;
51-
import org.slf4j.Marker;
5251
import org.slf4j.MDC;
52+
import org.slf4j.Marker;
53+
import org.slf4j.impl.StaticMarkerBinder;
5354

5455
import java.io.IOException;
5556
import java.util.Collections;
@@ -70,7 +71,7 @@ public class QueryTracker extends AbstractService {
7071

7172
private static final Logger LOG = LoggerFactory.getLogger(QueryTracker.class);
7273
private static final Marker QUERY_COMPLETE_MARKER =
73-
new Log4jMarker(new Log4jQueryCompleteMarker());
74+
new Log4jMarker(StaticMarkerBinder.getSingleton().getMarkerFactory(), new Log4jQueryCompleteMarker());
7475

7576
/// Shared singleton MetricsSource instance for all DAG locks
7677
private static final MetricsSource LOCK_METRICS;

llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonLogging.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import org.apache.hadoop.security.token.Token;
2626
import org.apache.hive.testutils.junit.extensions.DoNothingTCPServer;
2727
import org.apache.hive.testutils.junit.extensions.DoNothingTCPServerExtension;
28-
import org.apache.logging.log4j.junit.LoggerContextSource;
28+
import org.apache.logging.log4j.core.test.junit.LoggerContextSource;
2929
import org.apache.tez.common.security.TokenCache;
3030

3131
import org.junit.jupiter.api.Test;

pom.xml

+1-2
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@
175175
<!-- Leaving libfb303 at 0.9.3 regardless of libthrift: As per THRIFT-4613 The Apache Thrift project does not publish items related to fb303 at this point -->
176176
<libfb303.version>0.9.3</libfb303.version>
177177
<libthrift.version>0.16.0</libthrift.version>
178-
<log4j2.version>2.18.0</log4j2.version>
178+
<log4j2.version>2.24.3</log4j2.version>
179179
<mariadb.version>2.5.0</mariadb.version>
180180
<mssql.version>6.2.1.jre8</mssql.version>
181181
<mysql.version>8.2.0</mysql.version>
@@ -1798,7 +1798,6 @@
17981798
<log4j.configurationFile>${test.log4j.scheme}${test.conf.dir}/hive-log4j2.properties</log4j.configurationFile>
17991799
<hive.test.console.log.level>${test.console.log.level}</hive.test.console.log.level>
18001800
<hive.cluster.id>hive-test-cluster-id-cli</hive.cluster.id>
1801-
<log4j.debug>true</log4j.debug>
18021801
<!-- don't dirty up /tmp -->
18031802
<java.io.tmpdir>${test.tmp.dir}</java.io.tmpdir>
18041803
<!-- Hadoop's minidfs class uses this -->

standalone-metastore/metastore-server/pom.xml

+6-2
Original file line numberDiff line numberDiff line change
@@ -418,9 +418,13 @@
418418
</dependency>
419419
<dependency>
420420
<groupId>org.apache.logging.log4j</groupId>
421-
<artifactId>log4j-core</artifactId>
421+
<artifactId>log4j-core-test</artifactId>
422422
<version>${log4j2.version}</version>
423-
<classifier>tests</classifier>
423+
<scope>test</scope>
424+
</dependency>
425+
<dependency>
426+
<groupId>org.junit.vintage</groupId>
427+
<artifactId>junit-vintage-engine</artifactId>
424428
<scope>test</scope>
425429
</dependency>
426430
</dependencies>

standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
import org.apache.logging.log4j.LogManager;
4545
import org.apache.logging.log4j.core.LoggerContext;
4646
import org.apache.logging.log4j.core.config.LoggerConfig;
47-
import org.apache.logging.log4j.test.appender.ListAppender;
47+
import org.apache.logging.log4j.core.test.appender.ListAppender;
4848
import org.apache.thrift.TException;
4949
import org.hamcrest.core.IsNot;
5050
import org.junit.After;

standalone-metastore/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
<junit.vintage.version>5.11.2</junit.vintage.version>
9090
<libfb303.version>0.9.3</libfb303.version>
9191
<libthrift.version>0.16.0</libthrift.version>
92-
<log4j2.version>2.18.0</log4j2.version>
92+
<log4j2.version>2.24.3</log4j2.version>
9393
<mockito-core.version>3.4.4</mockito-core.version>
9494
<orc.version>1.9.4</orc.version>
9595
<protobuf.version>3.25.5</protobuf.version>

0 commit comments

Comments
 (0)