Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on points not being in plane. #208

Closed
Kevin-Mattheus-Moerman opened this issue Oct 31, 2024 · 3 comments
Closed

Warning on points not being in plane. #208

Kevin-Mattheus-Moerman opened this issue Oct 31, 2024 · 3 comments

Comments

@Kevin-Mattheus-Moerman
Copy link

With the Comodo integration/use of your package, I am currently getting this warning:

┌ Warning: The provided points are not in the plane. All but the first two coordinates of each point will be ignored.
└ @ DelaunayTriangulation ~/.julia/packages/DelaunayTriangulation/74rOt/src/algorithms/triangulation/check_args.jl:114

This is because the Delaunay triangulations occur of course in 3D. However, all point sets and treatments of them in Comodo are always 3D. If Delaunay triangulation is used then it is always for planar point sets where the 3rd coordinate can safely be ignored. Hence I was wondering, since I keep getting this warning, if this warning is actually needed/relevant. Folks probably should know your package does the 2D Delaunay triangulation and ignores the 3rd dimension. So perhaps a statement on the documentation saying that any higher dimensions are ignored, would be good/sufficient, instead of the warning?

@DanielVandH
Copy link
Member

DanielVandH commented Oct 31, 2024

This was added in response to the issue #177 where a user did think that 3D might work. It should only be showing once, right? Is it showing more than once?

I don't mind whether or not the warning is removed though, I'd probably merge a PR that does that but adds a warning somewhere in the README & docs re-emphasising that coordinates past $x$ and $y$ are ignored.

@Kevin-Mattheus-Moerman
Copy link
Author

Yes, I think it occurs once.

I have no strong feelings either way. I think a statement like that is fine.

@DanielVandH
Copy link
Member

The main reason I decided with the warning over just re-emphasising it was because it might not be immediately obvious to new users that the coordinates are being ignored, since it's just being ignored silently. Sometimes things just silently working / not working can be a bit confusing for new users I think.

If you think it becomes a bit too annoying there might be a better compromise somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants