Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PrecompileTools #214

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Remove PrecompileTools #214

merged 1 commit into from
Nov 24, 2024

Conversation

DanielVandH
Copy link
Member

It's a tradeoff between latency and precompilation but Makie users don't really need to care about this package so it's unfair to them to give them precompilation.

@DanielVandH DanielVandH linked an issue Nov 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.82%. Comparing base (f64aefb) to head (8eac32e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   94.82%   94.82%   -0.01%     
==========================================
  Files         103      102       -1     
  Lines       10364    10349      -15     
==========================================
- Hits         9828     9813      -15     
  Misses        536      536              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@DanielVandH DanielVandH merged commit 27d90af into main Nov 24, 2024
7 of 9 checks passed
@DanielVandH DanielVandH deleted the rmpc branch November 24, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look into precompilation time
1 participant