reduce allocation in Record array construction (#114)

Moelf · web-flow · commit 1af9378753a2 · 2024-10-23T10:41:20.000-04:00
diff --git a/src/all_implementations.jl b/src/all_implementations.jl
@@ -1931,11 +1931,11 @@ RecordArray(
     behavior::Symbol = :default,
 ) where {FIELDS,CONTENTS<:Base.Tuple{Vararg{Content}}} = RecordArray(
     contents,
-    minimum(if length(contents) == 0
+    if isempty(contents)
         0
     else
-        [length(x) for x in contents]
-    end),
+        minimum(length, contents)
+    end,
     parameters = parameters,
     behavior = behavior,
 )

Original file line number	Diff line number	Diff line change
`@@ -1931,11 +1931,11 @@ RecordArray(`
`1931`	`1931`	`behavior::Symbol = :default,`
`1932`	`1932`	`) where {FIELDS,CONTENTS<:Base.Tuple{Vararg{Content}}} = RecordArray(`
`1933`	`1933`	`contents,`
`1934`		`- minimum(if length(contents) == 0`
	`1934`	`+ if isempty(contents)`
`1935`	`1935`	`0`
`1936`	`1936`	`else`
`1937`		`- [length(x) for x in contents]`
`1938`		`- end),`
	`1937`	`+ minimum(length, contents)`
	`1938`	`+ end,`
`1939`	`1939`	`parameters = parameters,`
`1940`	`1940`	`behavior = behavior,`
`1941`	`1941`	`)`