Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mda.fetch_pdb() to generate Universe from Protein Databank structures #4907

Open
orbeckst opened this issue Feb 8, 2025 · 5 comments · May be fixed by #4943
Open

mda.fetch_pdb() to generate Universe from Protein Databank structures #4907

orbeckst opened this issue Feb 8, 2025 · 5 comments · May be fixed by #4943

Comments

@orbeckst
Copy link
Member

orbeckst commented Feb 8, 2025

Is your feature request related to a problem?

We used to have mda.fetch_mmtf() to get a structure from the PDB but with the demise of MMTF, this was removed around release 2.6 or so.

Describe the solution you'd like

It would be very convenient to have mda.fetch_pdb(PDB_ID) to create a Universe from the entry in the Protein Databank with ID PDB_ID.

Describe alternatives you've considered

VMD (load molecule), pymol (fetch) and Chimera (fetch by ID) can do this.

Alternatively, keep using this bash script or wget/curl.

Additional context

We will need the mmcif reader #2367 .

See also #3377 (fetch from alphafold database).

@BradyAJohnston
Copy link
Member

I have downloading / fetching from PDB and AFDB in Molecular Nodes here: https://github.com/BradyAJohnston/MolecularNodes/blob/main/molecularnodes/download.py

Would be happy to work on implementation for MDA.

@jauy123
Copy link
Contributor

jauy123 commented Feb 22, 2025

I wouldn't mind working on this as a little side project. Are issues assigned to people for MDAnalysis, or is it just open a pull request and have everyone look at your code once you have a working implementation?

@orbeckst
Copy link
Member Author

The latter - we only assign issues in specific cases where this has been planned.

In general, put up a PR! We very much welcome new contributions. As a basic rule, you’ll need tests that cover your code and your tests need to run (and old tests should not fail). See https://userguide.mdanalysis.org/stable/contributing_code.html for more details on how to contribute.

Feel free to ask questions on the PR for specifics. Just be aware that people are busy and it can take a day or two until people have time.

@orbeckst
Copy link
Member Author

@BradyAJohnston given that you already have a working implementation under a reasonable license, could @jauy123 just get started with using yours and you could help with reviewing (as opposed to having to do all the work)? If this gets merged then we could put both your names on the contribution.

(Disclosure: @jauy123 is working in my research group)

@BradyAJohnston
Copy link
Member

Yep I haven't got time to work on it anytime soon so that would be great. Happy to have them re-use the code!

@jauy123 jauy123 linked a pull request Mar 3, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants