Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test DDP parallelism without usage of mock #680

Open
dorotat-nv opened this issue Feb 6, 2025 · 0 comments
Open

test DDP parallelism without usage of mock #680

dorotat-nv opened this issue Feb 6, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@dorotat-nv
Copy link
Collaborator

dorotat-nv commented Feb 6, 2025 •
edited
Loading

Problem & Motivation

Directly test parallelism setting for DDP. Currentlyit is tested in sub-packages/bionemo-testing/tests/bionemo/testing/test_megatron_parallel_state_utils.py using mock

BioNeMo Framework Version

9cec09f

Category

Model/Training

Proposed Solution

Reimplement tests in sub-packages/bionemo-testing/tests/bionemo/testing/test_megatron_parallel_state_utils.py to replace mock with the actual lightning module using different levels of parallelism and compare it to the base case (ie no ddp)

Expected Benefits

improved scope of testing

Code Example


      		
    

      
  





        

            


            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @dorotat-nv
dorotat-nv




          added
  the 

  enhancement

  New feature or request
 label


      Feb 6, 2025

    

  



  

  

    
  


  

      

    @dorotat-nv
dorotat-nv



    mentioned this issue
    
      Feb 6, 2025
    





  


  

      
   Merged

  







  




    

    

      
    

    


      

          @dorotat-nv
dorotat-nv




        changed the title
test DDP parallelism without using of mock

test DDP parallelism without usage of mock


      Feb 6, 2025

    

  












  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                    




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    enhancement

  New feature or request








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
    
No branches or pull requests







      
    

  




      

    

  
      

  

    

      1 participant
    

    

        
          @dorotat-nv