Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split padding logic out of the batch collate function. #718

Open
jstjohn opened this issue Mar 5, 2025 · 0 comments
Open

Split padding logic out of the batch collate function. #718

jstjohn opened this issue Mar 5, 2025 · 0 comments

Comments

@jstjohn
Copy link
Collaborator

jstjohn commented Mar 5, 2025 

          IMO this should get pulled out into a separate `pad` function, otherwise we're hiding a lot of magic in the collation function

Originally posted by @pstjohn in #694 (comment)
@jstjohn jstjohn mentioned this issue Mar 5, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jstjohn