dell-xps-15-9570: fix imports, refactor (closer to recent profiles and more explicit) (#1331)

Author: matthieucx

dell/xps/15-9570/default.nix

@@ -1,11 +1,6 @@
 { lib, ... }:
 {
   imports = [
-    ../../../common/cpu/intel/kaby-lake
-    ../../../common/pc/laptop
-    ./xps-common.nix
+    ./shared.nix
   ];
-
-  # Includes the Wi-Fi and Bluetooth firmware
-  hardware.enableRedistributableFirmware = lib.mkDefault true;
 }

dell/xps/15-9570/intel/default.nix

@@ -1,8 +1,8 @@
 {
   imports = [
-    ../../../../common/cpu/intel
-    ../../../../common/pc/laptop
     ../../../../common/gpu/nvidia/disable.nix
-    ../xps-common.nix
+    ../shared.nix
   ];
+
+  # Disables the Nvidia GPU, better for battery life
 }

dell/xps/15-9570/nvidia/default.nix

@@ -1,12 +1,9 @@
 { ... }:
-
 {
   imports = [
-    ../../../../common/cpu/intel
     ../../../../common/gpu/nvidia/prime.nix
     ../../../../common/gpu/nvidia/pascal
-    ../../../../common/pc/laptop
-    ../xps-common.nix
+    ../shared.nix
   ];
 
 

dell/xps/15-9570/shared.nix

@@ -0,0 +1,20 @@
+{ lib, ... }:
+{
+
+  imports = [ 
+    ../../../common/cpu/intel/coffee-lake
+    ../../../common/pc/laptop
+  ];
+
+  # Solution to rcu_sched freezing
+  boot.kernelParams = [ "acpi_rev_override" ];
+
+  # This will save you money and possibly your life!
+  # https://github.com/NixOS/nixos-hardware/pull/127
+  services.thermald.enable = lib.mkDefault true;
+
+  hardware.graphics = {
+    enable = lib.mkDefault true;
+    enable32Bit = lib.mkDefault true;
+  };
+}