wxGUI: Fix SIM115: Improve temporary file handling in modules component (#5406)

added context manger

Author: arohanajit

gui/wxpython/modules/colorrules.py

@@ -1548,8 +1548,13 @@ def LoadRulesFromColumn(self):
             columns += "," + self.properties["loadColumn"]
 
         sep = ";"
-        if self.inmap:
-            outFile = tempfile.NamedTemporaryFile(mode="w+")
+        if not self.inmap:
+            self.preview.EraseMap()
+            del busy
+            return
+
+        # Use a context manager for the file
+        with tempfile.NamedTemporaryFile(mode="w+") as outFile:
             ret = RunCommand(
                 "v.db.select",
                 quiet=True,
@@ -1560,65 +1565,61 @@ def LoadRulesFromColumn(self):
                 sep=sep,
                 stdout=outFile,
             )
-        else:
-            self.preview.EraseMap()
-            del busy
-            return
 
-        outFile.seek(0)
-        i = 0
-        minim = maxim = 0.0
-        limit = 1000
+            outFile.seek(0)
+            i = 0
+            minim = maxim = 0.0
+            limit = 1000
 
-        colvallist = []
-        readvals = False
+            colvallist = []
+            readvals = False
 
-        while True:
-            # os.linesep doesn't work here (MSYS)
-            record = outFile.readline().replace("\n", "")
-            if not record:
-                break
-            self.rulesPanel.ruleslines[i] = {}
+            while True:
+                # os.linesep doesn't work here (MSYS)
+                record = outFile.readline().replace("\n", "")
+                if not record:
+                    break
+                self.rulesPanel.ruleslines[i] = {}
 
-            if not self.properties["loadColumn"]:
-                col1 = record
-                col2 = None
-            else:
-                col1, col2 = record.split(sep)
-
-            minim = min(float(col1), minim)
-            maxim = max(float(col1), maxim)
-
-            # color rules list should only have unique values of col1, not all
-            # records
-            if col1 not in colvallist:
-                self.rulesPanel.ruleslines[i]["value"] = col1
-                self.rulesPanel.ruleslines[i][self.attributeType] = col2
-
-                colvallist.append(col1)
-                i += 1
-
-            if i > limit and readvals is False:
-                dlg = wx.MessageDialog(
-                    parent=self,
-                    message=_(
-                        "Number of loaded records reached %d, "
-                        "displaying all the records will be time-consuming "
-                        "and may lead to computer freezing, "
-                        "do you still want to continue?"
-                    )
-                    % i,
-                    caption=_("Too many records"),
-                    style=wx.YES_NO | wx.NO_DEFAULT | wx.ICON_QUESTION,
-                )
-                if dlg.ShowModal() == wx.ID_YES:
-                    readvals = True
-                    dlg.Destroy()
+                if not self.properties["loadColumn"]:
+                    col1 = record
+                    col2 = None
                 else:
-                    del busy
-                    dlg.Destroy()
-                    self.updateColumn = False
-                    return
+                    col1, col2 = record.split(sep)
+
+                minim = min(float(col1), minim)
+                maxim = max(float(col1), maxim)
+
+                # color rules list should only have unique values of col1, not all
+                # records
+                if col1 not in colvallist:
+                    self.rulesPanel.ruleslines[i]["value"] = col1
+                    self.rulesPanel.ruleslines[i][self.attributeType] = col2
+
+                    colvallist.append(col1)
+                    i += 1
+
+                if i > limit and readvals is False:
+                    dlg = wx.MessageDialog(
+                        parent=self,
+                        message=_(
+                            "Number of loaded records reached %d, "
+                            "displaying all the records will be time-consuming "
+                            "and may lead to computer freezing, "
+                            "do you still want to continue?"
+                        )
+                        % i,
+                        caption=_("Too many records"),
+                        style=wx.YES_NO | wx.NO_DEFAULT | wx.ICON_QUESTION,
+                    )
+                    if dlg.ShowModal() == wx.ID_YES:
+                        readvals = True
+                        dlg.Destroy()
+                    else:
+                        del busy
+                        dlg.Destroy()
+                        self.updateColumn = False
+                        return
 
         self.rulesPanel.AddRules(i, start=True)
         ret = self.rulesPanel.LoadRules()

pyproject.toml

@@ -286,8 +286,6 @@ ignore = [
 "gui/wxpython/iclass/statistics.py" = ["A005"]
 "gui/wxpython/icons/grass_icons.py" = ["PTH208"]
 "gui/wxpython/image2target/ii2t_manager.py" = ["PTH208", "SIM115"]
-"gui/wxpython/modules/colorrules.py" = ["SIM115"]
-"gui/wxpython/modules/mcalc_builder.py" = ["SIM115"]
 "gui/wxpython/photo2image/ip2i_manager.py" = ["SIM115"]
 "gui/wxpython/psmap/dialogs.py" = ["PTH208"]
 "gui/wxpython/psmap/instructions.py" = ["SIM115"]