Skip to content

Commit e952443

Browse files
authored
style: Fix replace-stdout-stderr (UP022) (#4000)
Using `ruff check --output-format=concise --preview --select UP022 --unsafe-fixes --fix`
1 parent cd64472 commit e952443

File tree

5 files changed

+4
-9
lines changed

5 files changed

+4
-9
lines changed

pyproject.toml

-1
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,6 @@ ignore = [
319319
"TRY302", # useless-try-except
320320
"UP015", # redundant-open-modes
321321
"UP018", # native-literals
322-
"UP022", # replace-stdout-stderr
323322
"UP030", # format-literals
324323
"UP031", # printf-string-formatting
325324
"UP032", # f-string

python/grass/gunittest/invoker.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,7 @@ def _run_test_module(self, module, results_dir, gisdbase, location, timeout):
196196
args,
197197
cwd=cwd,
198198
env=env,
199-
stdout=subprocess.PIPE,
200-
stderr=subprocess.PIPE,
199+
capture_output=True,
201200
timeout=timeout,
202201
check=False,
203202
)

utils/generate_last_commit_file.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@ def get_last_commit(src_dir):
6565
f"--format=%H,{COMMIT_DATE_FORMAT}",
6666
rel_path,
6767
],
68-
stdout=subprocess.PIPE,
69-
stderr=subprocess.PIPE,
68+
capture_output=True,
7069
) # --format=%H,COMMIT_DATE_FORMAT commit hash,author date
7170
if process_result.returncode == 0:
7271
try:

utils/mkhtml.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -380,8 +380,7 @@ def has_src_code_git(src_dir, is_addon):
380380
f"--format=%H,{COMMIT_DATE_FORMAT}",
381381
src_dir,
382382
],
383-
stderr=subprocess.PIPE,
384-
stdout=subprocess.PIPE,
383+
capture_output=True,
385384
) # --format=%H,COMMIT_DATE_FORMAT commit hash,author date
386385
os.chdir(actual_dir)
387386
return process_result if process_result.returncode == 0 else None

utils/test_generate_last_commit_file.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,7 @@ def test_compare_json_file_data(read_json_file, core_module_path):
8383
f"--format=%H,{COMMIT_DATE_FORMAT}",
8484
core_module_path,
8585
],
86-
stdout=subprocess.PIPE,
87-
stderr=subprocess.PIPE,
86+
capture_output=True,
8887
check=True,
8988
) # --format=%H,COMMIT_DATE_FORMAT commit hash,author date
9089
commit, date = process_result.stdout.decode().strip().split(",")

0 commit comments

Comments
 (0)