Skip to content

Commit eb5932a

Browse files
committed
GH Actions: selectively use fail-fast with setup-php
I've seen some recent build failures due to the `setup-php` action running into a rate limit and not downloading the required version of Composer. In the case of this package, that would make the test runs worthless. The `setup-php` action runner defaults to _showing_ these type errors in the logs, but not stopping the workflow run. So, specifically for those jobs where the Composer version is important, I'm adding the `fail-fast` option to `setup-php` to fail the build if the action runner ran into any errors. Ref: https://github.com/shivammathur/setup-php#fail-fast-optional
1 parent 77cfd99 commit eb5932a

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

.github/workflows/integrationtest.yml

+1
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ jobs:
122122
ini-values: zend.assertions=1, error_reporting=-1, display_errors=On
123123
tools: "composer:${{ matrix.composer }}"
124124
coverage: none
125+
fail-fast: true
125126

126127
- name: "Conditionally disable tls (Composer 1.x/Windows/PHP 5.4)"
127128
if: ${{ matrix.os == 'windows-latest' && matrix.composer == 'v1' && matrix.php == '5.4' }}

.github/workflows/quicktest.yml

+1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ jobs:
4949
ini-values: zend.assertions=1, error_reporting=-1, display_errors=On
5050
tools: "composer:${{ matrix.composer }}"
5151
coverage: none
52+
fail-fast: true
5253

5354
- name: "Conditionally disable tls (Composer 1.x/Windows/PHP 5.4)"
5455
if: ${{ matrix.os == 'windows-latest' && matrix.composer == 'v1' && matrix.php == '5.4' }}

0 commit comments

Comments
 (0)