Skip to content

Commit 0734944

Browse files
authored
Don't convert forts to feudal holdings in non-capital baronies for tribal realms (#2381) #patch
1 parent e944c01 commit 0734944

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

ImperatorToCK3.UnitTests/CK3/Provinces/ProvinceTests.cs

+3-1
Original file line numberDiff line numberDiff line change
@@ -170,14 +170,16 @@ public void SetHoldingLogicWorksCorrectlyForAllGovernmentTypes() {
170170
" = { province_rank=city_metropolis holy_site=69 fort=yes }",
171171
" = { province_rank=city_metropolis fort=yes }",
172172
" = { province_rank=city_metropolis }",
173+
" = { province_rank=settlement fort=yes}",
173174
" = { province_rank=settlement }",
174175
});
175176
ck3Provinces = GetCK3ProvincesForIRGovernment(irProvinces, "tribal_federation");
176177
holdingTypes = ck3Provinces.Select(p => p.GetHoldingType(ck3BookmarkDate));
177178
holdingTypes.Should().Equal(
178179
"church_holding",
179-
"castle_holding",
180+
"city_holding", // For non-capital baronies of tribal realms, forts are not converted to castles.
180181
"city_holding",
182+
"none", // For non-capital baronies of tribal realms, forts are not converted to castles.
181183
"none"
182184
);
183185
}

ImperatorToCK3/CK3/Provinces/Province.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ private void SetHoldingFromImperator(Title.LandedTitles landedTitles) {
258258
} => "church_holding",
259259
{
260260
IsCountyCapital: false,
261-
GovernmentType: GovernmentType.monarchy or GovernmentType.tribal,
261+
GovernmentType: GovernmentType.monarchy,
262262
Fort: true
263263
} => "castle_holding",
264264
{

0 commit comments

Comments
 (0)