Handle DNA generation exceptions (#2409) #patch

IhateTrains · web-flow · commit 35eece4ce6e2 · 2025-01-09T02:04:49.000Z
Report: https://forum.paradoxplaza.com/forum/threads/imperator-to-ck3-development-thread.1415175/post-30103921 https://forum.paradoxplaza.com/forum/threads/imperator-to-ck3-development-thread.1415175/post-30104168
diff --git a/ImperatorToCK3/CK3/Characters/CharacterCollection.cs b/ImperatorToCK3/CK3/Characters/CharacterCollection.cs
@@ -820,7 +820,11 @@ internal void ConvertImperatorCharacterDNA(DNAFactory dnaFactory) {
 			
 			PortraitData? portraitData = character.ImperatorCharacter.PortraitData;
 			if (portraitData is not null) {
-				character.DNA = dnaFactory.GenerateDNA(character.ImperatorCharacter, portraitData);
+				try {
+					character.DNA = dnaFactory.GenerateDNA(character.ImperatorCharacter, portraitData);
+				} catch (Exception e) {
+					Logger.Warn($"Failed to generate DNA for character {character.Id}: {e.Message}");
+				}
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -820,7 +820,11 @@ internal void ConvertImperatorCharacterDNA(DNAFactory dnaFactory) {`
`820`	`820`
`821`	`821`	`PortraitData? portraitData = character.ImperatorCharacter.PortraitData;`
`822`	`822`	`if (portraitData is not null) {`
`823`		`- character.DNA = dnaFactory.GenerateDNA(character.ImperatorCharacter, portraitData);`
	`823`	`+ try {`
	`824`	`+ character.DNA = dnaFactory.GenerateDNA(character.ImperatorCharacter, portraitData);`
	`825`	`+ } catch (Exception e) {`
	`826`	`+ Logger.Warn($"Failed to generate DNA for character {character.Id}: {e.Message}");`
	`827`	`+ }`
`824`	`828`	`}`
`825`	`829`	`}`
`826`	`830`	`}`