Skip to content

Commit c86bccf

Browse files
authored
fix(sharing): adding back resolvedUrl for the derivers (#1408)
1 parent 303f548 commit c86bccf

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

clients/web/src/common/api/derivers/item.js

+2
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,8 @@ export function deriveItemData({
209209
publisher: publisher({ item, itemEnrichment, passedPublisher }),
210210
publisherLogo: item?.domainMetadata?.logo || false,
211211
externalUrl: externalUrl({ item, itemEnrichment, utmId }),
212+
// Temporary fix for the share modal and other possible areas that need the external url
213+
resolvedUrl: externalUrl({ item, itemEnrichment, utmId }),
212214
readUrl: readUrl({ item, node, status: node?.status }),
213215
itemUrl: node?.url || null,
214216
saveUrl: saveUrl({ item, itemEnrichment }),

clients/web/src/components/item/item.js

-1
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ export const Item = (props) => {
163163
className="content-block"
164164
data-testid="content-block"
165165
target={linkTarget}
166-
ref={linkRef}
167166
rel={linkRel}>
168167
<div className="content">
169168
{fromPartner ? <PartnerOverline partnerType={partnerType} /> : null}

clients/web/src/connectors/items/mutation-share.state.js

+1
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ export const mutationShareSagas = [
5757
--------------------------------------------------------------- */
5858
function* getShareableLink({ item, quote, note }) {
5959
try {
60+
//TODO: Ask @collectedmind if this should be externalUrl moving forward
6061
const target = item.resolvedUrl
6162
const context = buildContext(quote, note)
6263
const response = yield shareCreateLink(target, context)

0 commit comments

Comments
 (0)