fix(items): add some fidelity to unresolved zombie items

Author: collectedmind

clients/web/src/common/api/derivers/item.js

@@ -205,7 +205,7 @@ export function deriveItemData({
     authors: item?.preview?.authors || itemEnrichment?.authors || item?.authors || false,
     title: title({ item, itemEnrichment, node }),
     thumbnail: thumbnail({ item, itemEnrichment }),
-    excerpt: excerpt({ item, itemEnrichment }),
+    excerpt: excerpt({ item, itemEnrichment, node }),
     publisher: publisher({ item, itemEnrichment, passedPublisher }),
     publisherLogo: item?.domainMetadata?.logo || false,
     externalUrl: externalUrl({ item, itemEnrichment, utmId }),
@@ -302,12 +302,13 @@ function publisher({ item, itemEnrichment, passedPublisher }) {
  * @param {object} curatedInfo Additional information provided by the curation team
  * @returns {string} The most appropriate excerpt to show
  */
-function excerpt({ item, itemEnrichment }) {
+function excerpt({ item, itemEnrichment, node }) {
   return (
     item?.preview?.excerpt ||
     itemEnrichment?.excerpt ||
     item?.collection?.excerpt ||
     item?.excerpt ||
+    node?.url ||
     null
   )
 }

clients/web/src/common/api/derivers/list/image.spec.js

@@ -88,7 +88,9 @@ describe('Saves - Image', () => {
       'https://pocket-image-cache.com/600x/filters:format(jpg):extract_focal()/https%3A%2F%2Fcdn.dribbble.com%2Fusers%2F59947%2Fscreenshots%2F16700535%2Fmedia%2F335d386abb459f49570030e830429cef.jpg'
     )
     expect(item.publisher).toBe('cdn.dribbble.com')
-    expect(item.excerpt).toBeFalsy()
+    expect(item.excerpt).toBe(
+      'https://cdn.dribbble.com/users/59947/screenshots/16700535/media/335d386abb459f49570030e830429cef.jpg'
+    )
     expect(item.saveUrl).toBe(expectedSaveUrl)
     expect(item.externalUrl).toBe(expectedExternalUrl)
     expect(item.readUrl).toBe(expectedReadUrl)

clients/web/src/common/api/queries/get-saved-items.js

@@ -17,6 +17,9 @@ const getSavedItemsQuery = gql`
         edges {
           cursor
           node {
+            nodeId: id
+            url
+            title
             _createdAt
             _updatedAt
             status

clients/web/src/connectors/items/items-saved.state.js

@@ -99,7 +99,7 @@ function* savedItemRequest(action) {
     const savedItemIds = edges
       .filter(validateEdge)
       .filter(removeStarterArticle)
-      .map((edge) => edge?.node?.item?.itemId)
+      .map((edge) => edge?.node?.item?.itemId ?? edge?.node?.nodeId)
 
     const nodes = edges.reduce(getNodeFromEdge, {})
     const itemsById = edges.reduce(getItemFromEdge, {})
@@ -207,26 +207,30 @@ const removeStarterArticle = (edge) => !STARTER_ARTICLES.includes(edge?.node?.it
 const getNodeFromEdge = (previous, current) => {
   const cursor = current.cursor
   const { item, ...node } = current.node
+  const itemId = node?.item?.itemId ?? node?.nodeId
   if (node.status === 'DELETED') return previous // REMOVE DELETED ITEMS FROM THE RESPONSE
-  return { ...previous, [item.itemId]: { cursor, ...node } }
+  return { ...previous, [itemId]: { cursor, ...node } }
 }
 
 const getItemFromEdge = (previous, current) => {
   const { item, node } = deriveSavedItem(current.node)
+  const itemId = node?.item?.itemId ?? node?.nodeId
   if (node.status === 'DELETED') return previous
-  return { ...previous, [item.itemId]: item } // REMOVE DELETED ITEMS FROM THE RESPONSE
+  return { ...previous, [itemId]: item } // REMOVE DELETED ITEMS FROM THE RESPONSE
 }
 
 const getSearchNodeFromEdge = (previous, current) => {
   const { item, ...node } = current.node.savedItem
+  const itemId = node?.item?.itemId ?? node?.nodeId
   if (node.status === 'DELETED') return previous
-  return { ...previous, [item.itemId]: node } // REMOVE DELETED ITEMS FROM THE RESPONSE
+  return { ...previous, [itemId]: node } // REMOVE DELETED ITEMS FROM THE RESPONSE
 }
 
 const getSearchItemFromEdge = (previous, current) => {
   const { item, node } = deriveSavedItem(current.node.savedItem)
+  const itemId = node?.item?.itemId ?? node?.nodeId
   if (node.status === 'DELETED') return previous
-  return { ...previous, [item.itemId]: item } // REMOVE DELETED ITEMS FROM THE RESPONSE
+  return { ...previous, [itemId]: item } // REMOVE DELETED ITEMS FROM THE RESPONSE
 }
 
 /**