Remove UnixConsoleEcho now that PS6 is unsupported

Author: andyleejordan

.vsts-ci/templates/release-general.yml

@@ -46,7 +46,6 @@ steps:
       **/Newtonsoft.Json.dll
       **/OmniSharp*.dll
       **/Serilog*.dll
-      **/UnixConsoleEcho.dll
 
 # The SBOM generation requires our original sources with the `dotnet restore`
 # produced `project.assets.json` files.

Third Party Notices.txt

@@ -4,21 +4,6 @@ This file is based on or incorporates material from the projects listed below (T
 
 ---
 
-UnixConsoleEcho
-
-Copyright (c) 2017 Patrick Meinecke
-Provided for Informational Purposes Only
-
-MIT License
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the Software), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
----
-
 Serilog
 
 Copyright 2013-2015 Serilog Contributors

src/PowerShellEditorServices/PowerShellEditorServices.csproj

@@ -38,7 +38,6 @@
     <PackageReference Include="System.IO.Pipes.AccessControl" Version="5.0.0" />
     <PackageReference Include="System.Security.Principal" Version="4.3.0" />
     <PackageReference Include="System.Security.Principal.Windows" Version="5.0.0" />
-    <PackageReference Include="UnixConsoleEcho" Version="0.1.0" />
   </ItemGroup>
 
   <ItemGroup>

src/PowerShellEditorServices/Services/PowerShell/Console/UnixConsoleOperations.cs

@@ -5,7 +5,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.PowerShell.EditorServices.Utility;
-using UnixConsoleEcho;
 
 namespace Microsoft.PowerShell.EditorServices.Services.PowerShell.Console
 {
@@ -43,35 +42,19 @@ public ConsoleKeyInfo ReadKey(bool intercept, CancellationToken cancellationToke
             // On Unix platforms System.Console.ReadKey has an internal lock on stdin.  Because
             // of this, if a ReadKey call is pending in one thread and in another thread
             // Console.CursorLeft is called, both threads block until a key is pressed.
-
-            // To work around this we wait for a key to be pressed before actually calling Console.ReadKey.
-            // However, any pressed keys during this time will be echoed to the console. To get around
-            // this we use the UnixConsoleEcho package to disable echo prior to waiting.
-            if (VersionUtils.IsPS6)
-            {
-                InputEcho.Disable();
-            }
-
             try
             {
                 // The WaitForKeyAvailable delegate switches between a long delay between waits and
                 // a short timeout depending on how recently a key has been pressed. This allows us
                 // to let the CPU enter low power mode without compromising responsiveness.
-                while (!WaitForKeyAvailable(cancellationToken))
-                {
-                    ;
-                }
+                while (!WaitForKeyAvailable(cancellationToken)) { }
             }
             finally
             {
-                if (VersionUtils.IsPS6)
-                {
-                    InputEcho.Disable();
-                }
                 s_readKeyHandle.Release();
             }
 
-            // A key has been pressed, so aquire a lock on our internal stdin handle. This is done
+            // A key has been pressed, so acquire a lock on our internal stdin handle. This is done
             // so any of our calls to cursor position API's do not release ReadKey.
             s_stdInHandle.Wait(cancellationToken);
             try
@@ -88,26 +71,12 @@ public async Task<ConsoleKeyInfo> ReadKeyAsync(bool intercept, CancellationToken
         {
             await s_readKeyHandle.WaitAsync(cancellationToken).ConfigureAwait(false);
 
-            // I tried to replace this library with a call to `stty -echo`, but unfortunately
-            // the library also sets up allowing backspace to trigger `Console.KeyAvailable`.
-            if (VersionUtils.IsPS6)
-            {
-                InputEcho.Disable();
-            }
-
             try
             {
-                while (!await WaitForKeyAvailableAsync(cancellationToken).ConfigureAwait(false))
-                {
-                    ;
-                }
+                while (!await WaitForKeyAvailableAsync(cancellationToken).ConfigureAwait(false)) { }
             }
             finally
             {
-                if (VersionUtils.IsPS6)
-                {
-                    InputEcho.Enable();
-                }
                 s_readKeyHandle.Release();
             }