Skip to content

Commit c2a10d3

Browse files
committed
Use native methods for flaky test
1 parent c9b2288 commit c2a10d3

File tree

2 files changed

+21
-21
lines changed

2 files changed

+21
-21
lines changed

test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs

+18-19
Original file line numberDiff line numberDiff line change
@@ -1057,7 +1057,9 @@ public async Task CanSendCompletionAndCompletionResolveRequestAsync()
10571057
Assert.Contains("Writes customized output to a host", updatedCompletionItem.Documentation.String);
10581058
}
10591059

1060-
[SkippableFact(Skip = "Completion for Expand-SlowArchive is flaky.")]
1060+
1061+
// [SkippableFact(Skip = "Completion for Expand-SlowArchive is flaky.")]
1062+
[Fact]
10611063
public async Task CanSendCompletionResolveWithModulePrefixRequestAsync()
10621064
{
10631065
await PsesLanguageClient
@@ -1084,9 +1086,7 @@ await PsesLanguageClient
10841086
CompletionItem completionItem = Assert.Single(completionItems,
10851087
completionItem1 => completionItem1.Label == "Expand-SlowArchive");
10861088

1087-
CompletionItem updatedCompletionItem = await PsesLanguageClient
1088-
.SendRequest("completionItem/resolve", completionItem)
1089-
.Returning<CompletionItem>(CancellationToken.None);
1089+
CompletionItem updatedCompletionItem = await PsesLanguageClient.ResolveCompletion(completionItem);
10901090

10911091
Assert.Contains("Extracts files from a specified archive", updatedCompletionItem.Documentation.String);
10921092
}
@@ -1123,22 +1123,21 @@ public async Task CanSendSignatureHelpRequestAsync()
11231123
{
11241124
string filePath = NewTestFile("Get-Date -");
11251125

1126-
SignatureHelp signatureHelp = await PsesLanguageClient
1127-
.SendRequest(
1128-
"textDocument/signatureHelp",
1129-
new SignatureHelpParams
1126+
SignatureHelp signatureHelp = await PsesLanguageClient.RequestSignatureHelp
1127+
(
1128+
new SignatureHelpParams
1129+
{
1130+
TextDocument = new TextDocumentIdentifier
11301131
{
1131-
TextDocument = new TextDocumentIdentifier
1132-
{
1133-
Uri = new Uri(filePath)
1134-
},
1135-
Position = new Position
1136-
{
1137-
Line = 0,
1138-
Character = 10
1139-
}
1140-
})
1141-
.Returning<SignatureHelp>(CancellationToken.None);
1132+
Uri = new Uri(filePath)
1133+
},
1134+
Position = new Position
1135+
{
1136+
Line = 0,
1137+
Character = 10
1138+
}
1139+
}
1140+
);
11421141

11431142
Assert.Contains("Get-Date", signatureHelp.Signatures.First().Label);
11441143
}

test/PowerShellEditorServices.Test.E2E/xunit.runner.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
"$schema": "https://xunit.net/schema/current/xunit.runner.schema.json",
33
"appDomain": "denied",
44
"parallelizeTestCollections": true,
5-
"parallelAlgorithm": "aggressive",
5+
"parallelAlgorithm": "conservative",
66
"methodDisplay": "method",
77
"diagnosticMessages": true,
8-
"longRunningTestSeconds": 60
8+
"longRunningTestSeconds": 10,
9+
"showLiveOutput": true
910
}

0 commit comments

Comments
 (0)