Skip to content

Commit c8f1c3e

Browse files
committed
Bump GetCommandRequest to 2 minutes
It took longer than 1 minute in Github Actions!
1 parent 66346ce commit c8f1c3e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1230,7 +1230,8 @@ await PsesLanguageClient
12301230
Assert.Equal(0, evaluateResponseBody.VariablesReference);
12311231
}
12321232

1233-
[SkippableFact(Timeout = 60000)]
1233+
// getCommand gets all the commands in the system, and is not optimized and can take forever on CI systems
1234+
[SkippableFact(Timeout = 120000)]
12341235
public async Task CanSendGetCommandRequestAsync()
12351236
{
12361237
Skip.If(Environment.GetEnvironmentVariable("TF_BUILD") is not null,

test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
using Microsoft.PowerShell.EditorServices.Test.Shared.References;
2222
using Microsoft.PowerShell.EditorServices.Test.Shared.SymbolDetails;
2323
using Microsoft.PowerShell.EditorServices.Test.Shared.Symbols;
24-
using Microsoft.PowerShell.EditorServices.Utility;
2524
using OmniSharp.Extensions.LanguageServer.Protocol;
2625
using OmniSharp.Extensions.LanguageServer.Protocol.Models;
2726
using Xunit;
@@ -756,10 +755,10 @@ public async Task FindsReferencesOnEnumMember()
756755
Assert.Equal(symbols, GetOccurrences(FindsOccurrencesOnTypeSymbolsData.EnumMemberSourceDetails));
757756
}
758757

759-
[SkippableFact]
758+
// This test fetches every command in PS,
759+
[Fact]
760760
public async Task FindsDetailsForBuiltInCommand()
761761
{
762-
Skip.IfNot(VersionUtils.IsMacOS, "macOS gets the right synopsis but others don't.");
763762
SymbolDetails symbolDetails = await symbolsService.FindSymbolDetailsAtLocationAsync(
764763
GetScriptFile(FindsDetailsForBuiltInCommandData.SourceDetails),
765764
FindsDetailsForBuiltInCommandData.SourceDetails.StartLineNumber,

0 commit comments

Comments
 (0)