Merge branch 'main' into rename-function-customvisitor

Author: JustinGrote

.editorconfig

@@ -54,11 +54,11 @@ dotnet_diagnostic.CA1068.severity = error
 # CA1501: Avoid excessive inheritance
 dotnet_diagnostic.CA1501.severity = error
 # CA1502: Avoid excessive complexity
-dotnet_diagnostic.CA1502.severity = warning
+dotnet_diagnostic.CA1502.severity = silent
 # CA1505: Avoid unmaintainable code
 dotnet_diagnostic.CA1505.severity = error
 # CA1506: Avoid excessive class coupling
-dotnet_diagnostic.CA1506.severity = warning
+dotnet_diagnostic.CA1506.severity = silent
 # CA1507: Use nameof in place of string
 dotnet_diagnostic.CA1507.severity = error
 # CA1508: Avoid dead conditional code
@@ -95,22 +95,22 @@ dotnet_diagnostic.RCS1210.severity = error
 # RCS1036: Remove unnecessary blank line
 dotnet_diagnostic.RCS1036.severity = error
 # RCS1075: Avoid empty catch clause that catches System.Exception
-dotnet_diagnostic.RCS1075.severity = suggestion
+dotnet_diagnostic.RCS1075.severity = error
 # RCS1170: Use read-only auto-implemented property
 dotnet_diagnostic.RCS1170.severity = error
 
 # VSTHRD002: Avoid problematic synchronous waits
-dotnet_diagnostic.VSTHRD002.severity = suggestion
+dotnet_diagnostic.VSTHRD002.severity = error
 # VSTHRD003: Avoid awaiting foreign Tasks
-dotnet_diagnostic.VSTHRD003.severity = suggestion
+dotnet_diagnostic.VSTHRD003.severity = error
 # VSTHRD105: Avoid method overloads that assume TaskScheduler.Current
-dotnet_diagnostic.VSTHRD105.severity = suggestion
+dotnet_diagnostic.VSTHRD105.severity = error
 # VSTHRD100: Avoid async void methods
-dotnet_diagnostic.VSTHRD100.severity = suggestion
+dotnet_diagnostic.VSTHRD100.severity = error
 # VSTHRD103: Call async methods when in an async method
-dotnet_diagnostic.VSTHRD103.severity = suggestion
+dotnet_diagnostic.VSTHRD103.severity = error
 # VSTHRD110: Observe result of async calls
-dotnet_diagnostic.VSTHRD110.severity = suggestion
+dotnet_diagnostic.VSTHRD110.severity = error
 # VSTHRD114: Avoid returning a null Task
 dotnet_diagnostic.VSTHRD114.severity = error
 # VSTHRD200: Use "Async" suffix for awaitable methods

.github/dependabot.yml

@@ -3,7 +3,7 @@ changelog:
     labels:
       - Ignore
     authors:
-      - dependabot[bot]
+      - dependabot
   categories:
     - title: Enhancements & Features ✨
       labels:

.github/release.yml

@@ -4,9 +4,7 @@ on:
   push:
     branches: [ main ]
   pull_request:
-    # The branches below must be a subset of the branches above
     branches: [ main ]
-    paths-ignore: [ '**/*.md' ]
   merge_group:
     types: [ checks_requested ]
   schedule:
@@ -22,7 +20,6 @@ jobs:
     runs-on: ${{ matrix.os }}
     env:
       DOTNET_NOLOGO: true
-      DOTNET_CLI_TELEMETRY_OPTOUT: true
       DOTNET_GENERATE_ASPNET_CERTIFICATE: false
     steps:
       - name: Checkout repository
@@ -32,14 +29,11 @@ jobs:
         uses: actions/setup-dotnet@v4
         with:
           cache: true
-          cache-dependency-path: '**/packages.lock.json'
+          cache-dependency-path: '**/*.csproj'
           dotnet-version: |
             6.0.x
             7.0.x
             8.0.x
-          source-url: https://pkgs.dev.azure.com/mscodehub/PowerShellCore/_packaging/PowerShellCore_PublicPackages/nuget/v3/index.json
-        env:
-          NUGET_AUTH_TOKEN: ${{ secrets.AZURE_NUGET_TOKEN }}
 
       - name: Install PSResources
         shell: pwsh

.github/workflows/ci-test.yml

@@ -7,6 +7,8 @@ on:
     # The branches below must be a subset of the branches above
     branches: [ main ]
     paths-ignore: [ '**/*.md' ]
+  schedule:
+    - cron: '35 13 * * 4'
 
 jobs:
   analyze:
@@ -22,7 +24,6 @@ jobs:
       security-events: write
     env:
       DOTNET_NOLOGO: true
-      DOTNET_CLI_TELEMETRY_OPTOUT: true
       DOTNET_GENERATE_ASPNET_CERTIFICATE: false
     steps:
     - name: Checkout repository
@@ -32,10 +33,7 @@ jobs:
       uses: actions/setup-dotnet@v4
       with:
         cache: true
-        cache-dependency-path: '**/packages.lock.json'
-        source-url: https://pkgs.dev.azure.com/mscodehub/PowerShellCore/_packaging/PowerShellCore_PublicPackages/nuget/v3/index.json
-      env:
-        NUGET_AUTH_TOKEN: ${{ secrets.AZURE_NUGET_TOKEN }}
+        cache-dependency-path: '**/*.csproj'
 
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v3

.github/workflows/codeql-analysis.yml

@@ -16,7 +16,6 @@ jobs:
     runs-on: ubuntu-latest
     env:
       DOTNET_NOLOGO: true
-      DOTNET_CLI_TELEMETRY_OPTOUT: true
       DOTNET_GENERATE_ASPNET_CERTIFICATE: false
     steps:
       - name: Checkout repository
@@ -26,10 +25,7 @@ jobs:
         uses: actions/setup-dotnet@v4
         with:
           cache: true
-          cache-dependency-path: '**/packages.lock.json'
-          source-url: https://pkgs.dev.azure.com/mscodehub/PowerShellCore/_packaging/PowerShellCore_PublicPackages/nuget/v3/index.json
-        env:
-          NUGET_AUTH_TOKEN: ${{ secrets.AZURE_NUGET_TOKEN }}
+          cache-dependency-path: '**/*.csproj'
 
       - name: Install PSResources
         shell: pwsh

.github/workflows/emacs-test.yml

@@ -16,7 +16,6 @@ jobs:
     runs-on: ubuntu-latest
     env:
       DOTNET_NOLOGO: true
-      DOTNET_CLI_TELEMETRY_OPTOUT: true
       DOTNET_GENERATE_ASPNET_CERTIFICATE: false
     steps:
       - name: Checkout repository
@@ -26,10 +25,7 @@ jobs:
         uses: actions/setup-dotnet@v4
         with:
           cache: true
-          cache-dependency-path: '**/packages.lock.json'
-          source-url: https://pkgs.dev.azure.com/mscodehub/PowerShellCore/_packaging/PowerShellCore_PublicPackages/nuget/v3/index.json
-        env:
-          NUGET_AUTH_TOKEN: ${{ secrets.AZURE_NUGET_TOKEN }}
+          cache-dependency-path: '**/*.csproj'
 
       - name: Install PSResources
         shell: pwsh

.github/workflows/vim-test.yml

@@ -1,79 +1,8 @@
-_ReSharper*
-[Bb]in
-bin-nano
-obj
-objd
-out/
-tmp/
-.tmp
-App_Data
-*.user
-*.sln.cache
-*.suo
-TestResults
-test/emacs-session.json
-[Tt]humbs.db
-buildd.*
-release/
-*.log
-*.bak
-packages
-OACRTemp/
-build_logs/
-lock
-/public/inc/bldver.*
-/public/inc/sources.ver
-/data
-/target
-.corext/gen
-registered_data.ini
-.vs/
-.dotnet/
-module/Plaster
-module/PSScriptAnalyzer
-module/PSReadLine
-docs/_site/
-docs/_repo/
-docs/metadata/
-*.zip
-
-# Generated build info file
-src/PowerShellEditorServices.Hosting/BuildInfo.cs
-
-# quickbuild.exe
-/VersionGeneratingLogs/
-QLogs
-QLocal
-QTestLogs
-
-# bad tlb/chm generators in nmake tree
-*.tlb
-*.chm
-
-# dumb silverlight
-ClientBin/
-
-# dump azure
-*.build.csdef
-csx/
-
-# Don't include ScriptAnalyzer binaries
-PowerShellEditorServices/**
-PowerShellEditorServices.NoNano/**
-
-PowerShellEditorServices.sln.ide/edb.chk
-PowerShellEditorServices.sln.ide/edbres00001.jrs
-PowerShellEditorServices.sln.ide/storage.ide
-*.jrs
-
-# Don't include PlatyPS generated MAML
-module/PowerShellEditorServices/Commands/en-US/*-help.xml
-
-# Don't include Third Party Notices in module folder
-module/PowerShellEditorServices/Third\ Party\ Notices.txt
-
-# Visual Studio for Mac generated file
-*.userprefs
-
-# JetBrains generated file (Rider, intelliJ)
-.idea/
+bin/
+obj/
+module/PowerShellEditorServices/NOTICE.txt
+module/PowerShellEditorServices/Commands/en-US/
+module/Plaster/
+module/PSReadLine/
+module/PSScriptAnalyzer/
+TestResults/