Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp logger/logging #1796

Closed
SydneyhSmith opened this issue May 9, 2022 · 1 comment
Closed

Revamp logger/logging #1796

SydneyhSmith opened this issue May 9, 2022 · 1 comment
Labels
Area-Logging Issue-Enhancement A feature request (enhancement).

Comments

@SydneyhSmith
Copy link
Collaborator

We have a bunch of issues around logging to fix:

  • When we look for logs, what we're expecting is never there
  • The way we use the logger itself is explicitly marked as "inefficient" and wrong
  • The logger values are defined in three different ways
  • Most of the places we log an exception, we're not actually logging it

We should do this when we do telemetry, as part of an "observability" project.

@ghost ghost added the Needs: Triage Maintainer attention needed! label May 9, 2022
@SydneyhSmith SydneyhSmith added Area-Logging Issue-Enhancement A feature request (enhancement). and removed Needs: Triage Maintainer attention needed! labels May 24, 2022
@andyleejordan
Copy link
Member

andyleejordan commented Nov 15, 2024

@JustinGrote pretty much fixed all of this. #2200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Logging Issue-Enhancement A feature request (enhancement).
Projects
Status: Done
Development

No branches or pull requests

2 participants