bug: tracking issue: shared mutability

[Linus789]

Type

Error at runtime

Bug description

Occurred in ReVanced/revanced-patches#2177

Steps to reproduce

Two patches modify the same method but don’t use a mutableMethod to resolve the instruction indices, so that the indices of the original method are used which might be invalid after one patch has already modified the method.

Relevant log output

[0x93] register v6 has type Long (Low Half) but expected Precise Reference: java.lang.String

Screenshots or videos

No response

Solution

No response

Additional context

Temporary fix for spoof-wifi-connection implemented in ReVanced/revanced-patches#2199

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.

[LisoUseInAIKyrios]

Issue is fixed by using a class method pool starting with all immutable methods. After a mutable method is requested, the immutable method is upgraded to mutable and replaced in the pool. Then when other patches/fingerprints match, they match the instruction indexes of the newly modified method.

https://github.com/LisoUseInAIKyrios/revanced-patcher/blob/feat/instruction_filters/src/main/kotlin/app/revanced/patcher/util/PatchClasses.kt