Fix: Flow is not released when embedded in UINavigationController (#198)

mashe · Mikhail Markin · mgray88 · web-flow · commit e43955a032a3 · 2024-12-18T13:19:15.000-05:00
Co-authored-by: Mikhail Markin &lt;mikhail.markin@nordsec.com&gt;
Co-authored-by: Mike Gray &lt;mgray88@gmail.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,5 @@
 ** *Unreleased* **:
+- fix: flow is not released when embedded in UINavigationController
 - fix: presentable `allowStepWhenDismissed` now are not ignored and not overridden by parent flow
 - fix: `displayed` and `rxVisible` now do not assume UIViewController starts not visible
 
diff --git a/RxFlow/Extensions/Reactive+UIViewController.swift b/RxFlow/Extensions/Reactive+UIViewController.swift
@@ -17,7 +17,9 @@ public extension Reactive where Base: UIViewController {
     /// Rx observable, triggered when the view is being dismissed
     var dismissed: ControlEvent<Bool> {
         let dismissedSource = self.sentMessage(#selector(Base.viewDidDisappear))
-            .filter { [base] _ in base.isBeingDismissed }
+            .filter { [base] _ in
+                base.isBeingDismissed || base.navigationController?.isBeingDismissed == true
+            }
             .map { _ in false }
 
         let movedToParentSource = self.sentMessage(#selector(Base.didMove))

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`** Unreleased **:`
	`2`	`+- fix: flow is not released when embedded in UINavigationController`
`2`	`3`	- fix: presentable `allowStepWhenDismissed` now are not ignored and not overridden by parent flow
`3`	`4`	- fix: `displayed` and `rxVisible` now do not assume UIViewController starts not visible
`4`	`5`