Skip to content

Commit e43955a

Browse files
masheMikhail Markinmgray88
authored
Fix: Flow is not released when embedded in UINavigationController (#198)
Co-authored-by: Mikhail Markin <[email protected]> Co-authored-by: Mike Gray <[email protected]>
1 parent f51f6f9 commit e43955a

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
** *Unreleased* **:
2+
- fix: flow is not released when embedded in UINavigationController
23
- fix: presentable `allowStepWhenDismissed` now are not ignored and not overridden by parent flow
34
- fix: `displayed` and `rxVisible` now do not assume UIViewController starts not visible
45

RxFlow/Extensions/Reactive+UIViewController.swift

+3-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ public extension Reactive where Base: UIViewController {
1717
/// Rx observable, triggered when the view is being dismissed
1818
var dismissed: ControlEvent<Bool> {
1919
let dismissedSource = self.sentMessage(#selector(Base.viewDidDisappear))
20-
.filter { [base] _ in base.isBeingDismissed }
20+
.filter { [base] _ in
21+
base.isBeingDismissed || base.navigationController?.isBeingDismissed == true
22+
}
2123
.map { _ in false }
2224

2325
let movedToParentSource = self.sentMessage(#selector(Base.didMove))

0 commit comments

Comments
 (0)