updating call for bib update to have list - fixing tests

Author: acholyn

mod_app/models/feedback_model.py

@@ -30,4 +30,4 @@ def __str__(self):
     def save(self, *args, **kwargs):
         super().save(*args, **kwargs)
 
-        update_bibliography(self, self.content)
+        update_bibliography(self, [self.content])

mod_app/models/project_note_model.py

@@ -30,4 +30,4 @@ def __str__(self):
     def save(self, *args, **kwargs):
         super().save(*args, **kwargs)
 
-        update_bibliography(self, self.content)
+        update_bibliography(self, [self.content])

mod_app/models/teaching_analysis_models.py

@@ -55,7 +55,7 @@ def default_title():
     def save(self, *args, **kwargs):
         super().save(*args, **kwargs)
 
-        update_bibliography(self, self.content)
+        update_bibliography(self, [self.content])
 
 
 class TeachingResources(models.Model):
@@ -96,4 +96,4 @@ def default_title():
     def save(self, *args, **kwargs):
         super().save(*args, **kwargs)
 
-        update_bibliography(self, self.material)
+        update_bibliography(self, [self.material])

mod_app/utils/extract_citations.py

@@ -3,13 +3,16 @@
 
 
 def update_bibliography(self, fields):
-    bib_items = []
-    for field in fields:
-        bib_items.extend(get_bibliography_items(field))
-
-    # for each pk found add the bib item to the bibliography if it's changed
-    if list(self.bibliography.all()) != bib_items:
-        self.bibliography.set(bib_items)
+    # fields should be a list
+    if fields:
+        bib_items = []
+        for field in fields:
+            if field:
+                bib_items.extend(get_bibliography_items(field))
+
+        # for each pk found add the bib item to the bibliography if it's changed
+        if list(self.bibliography.all()) != bib_items:
+            self.bibliography.set(bib_items)
 
 
 def get_bibliography_items(field):