Skip to content

Commit 9c8f4f7

Browse files
committed
more integ-test fixes
1 parent ebefd19 commit 9c8f4f7

File tree

3 files changed

+33
-64
lines changed

3 files changed

+33
-64
lines changed

.github/workflows/tests.yml

+2-34
Original file line numberDiff line numberDiff line change
@@ -637,6 +637,7 @@ jobs:
637637
run: npm run integ-test -- -t 'quote for other networks * base'
638638
env:
639639
JSON_RPC_PROVIDER_BASE: ${{ secrets.JSON_RPC_PROVIDER_BASE }}
640+
JSON_RPC_PROVIDER_BASE_SEPOLIA: ${{ secrets.JSON_RPC_PROVIDER_BASE_SEPOLIA }}
640641
TENDERLY_BASE_URL: ${{ secrets.TENDERLY_BASE_URL }}
641642
TENDERLY_USER: ${{ secrets.TENDERLY_USER }}
642643
TENDERLY_PROJECT: ${{ secrets.TENDERLY_PROJECT }}
@@ -848,39 +849,6 @@ jobs:
848849
TENDERLY_PROJECT: ${{ secrets.TENDERLY_PROJECT }}
849850
TENDERLY_ACCESS_KEY: ${{ secrets.TENDERLY_ACCESS_KEY }}
850851

851-
integration-tests-quote-for-other-networks-base-sepolia:
852-
name: Integration Tests - Quote For Other Networks Base Sepolia
853-
runs-on: ubuntu-latest
854-
855-
steps:
856-
- uses: actions/checkout@v1
857-
- uses: actions/setup-node@v1
858-
with:
859-
node-version: 18.x
860-
registry-url: https://registry.npmjs.org
861-
862-
- uses: actions/cache@v3
863-
with:
864-
path: ~/.npm
865-
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
866-
restore-keys: |
867-
${{ runner.os }}-node-
868-
- name: Install dependencies
869-
run: npm install
870-
871-
# This is required separately from yarn test because it generates the typechain definitions
872-
- name: Compile
873-
run: npm run build
874-
875-
- name: Run Integration tests
876-
run: npm run integ-test -- -t 'quote for other networks * base sepolia'
877-
env:
878-
JSON_RPC_PROVIDER_MONAD_TESTNET: ${{ secrets.JSON_RPC_PROVIDER_BASE_SEPOLIA }}
879-
TENDERLY_BASE_URL: ${{ secrets.TENDERLY_BASE_URL }}
880-
TENDERLY_USER: ${{ secrets.TENDERLY_USER }}
881-
TENDERLY_PROJECT: ${{ secrets.TENDERLY_PROJECT }}
882-
TENDERLY_ACCESS_KEY: ${{ secrets.TENDERLY_ACCESS_KEY }}
883-
884852
integration-tests-quote-for-other-networks-remaining-networks:
885853
name: Integration Tests - Quote For Other Networks Remaining Networks
886854
runs-on: ubuntu-latest
@@ -908,7 +876,7 @@ jobs:
908876

909877
# This is to capture any new networks added into the integ-test suite
910878
- name: Run Integration tests
911-
run: npm run integ-test -- -t 'quote for other networks * (?!(mainnet|optimism|arbitrum|polygon|sepolia|celo|bnb|avalanche|base|blast|zora|zksync|worldchain|UNICHAIN-sepolia|monad-testnet|base-sepolia))'
879+
run: npm run integ-test -- -t 'quote for other networks * (?!(mainnet|optimism|arbitrum|polygon|sepolia|celo|bnb|avalanche|base|blast|zora|zksync|worldchain|unichain|monad-testnet))'
912880
env:
913881
# We don't know which new networks will be added, so we have no way to provider RPC URL ahead of time
914882
# This will make remaining networks integ-test suite to fail, and dev is expected to manually add RPC URL for the new network

package-lock.json

+27-27
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/integ/routers/alpha-router/alpha-router.integration.test.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ if (process.env.INTEG_TEST_DEBUG) {
264264
);
265265
}
266266

267-
jest.retryTimes(10);
267+
jest.retryTimes(0);
268268

269269
describe('alpha router integration', () => {
270270
let alice: JsonRpcSigner;
@@ -4035,12 +4035,13 @@ describe('quote for other networks', () => {
40354035

40364036
if (isTenderlyEnvironmentSet()) {
40374037
describe(`Simulate + Swap ${tradeType.toString()}`, function() {
4038-
// Tenderly does not support Celo
4038+
// Tenderly Node RPC does not support Celo, Blast, Zksync, BNB
40394039
if ([
40404040
ChainId.CELO,
40414041
ChainId.CELO_ALFAJORES,
40424042
ChainId.BLAST,
4043-
ChainId.ZKSYNC
4043+
ChainId.ZKSYNC,
4044+
ChainId.BNB,
40444045
].includes(chain)) {
40454046
return;
40464047
}

0 commit comments

Comments
 (0)